Fix: Correct image size calculation for macOS with NSImage #316
+23
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where
NSImage
was returning incorrect image sizes on macOS.Issue
minWidth
orminHeight
values.NSImage.size
method returns size information that is screen resolution dependent.minHeight
value of 1000, the resulting image size is 460 x 288, which is incorrect. This issue was observed on a Mac Mini connected to an LG monitor. It is unclear whether the same problem occurs with an iMac or an Apple external display.Details
NSImage.size
method withNSImageRep.pixelsWide
andNSImageRep.pixelsHigh
to get the actual image size.Testing