Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video_player_avplay] Remove set looping failed message #681

Merged
merged 2 commits into from
May 10, 2024
Merged

[video_player_avplay] Remove set looping failed message #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1bb8fa
Remove set looping failed message
xiaowei-guan May 9, 2024
ef0e769
Update CHANGELOG.md
xiaowei-guan May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/video_player_avplay/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Add notes for creating dash player.
* [Dash] Fix no EOS event of dashplayer.
* Remove set looping failed message.

## 0.4.1

Expand Down
2 changes: 1 addition & 1 deletion packages/video_player_avplay/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,4 +134,4 @@ This plugin has the following limitations.
- The `setPlaybackSpeed` method will fail if triggered within the last 3 seconds of the video.
- The playback speed will reset to 1.0 when the video is replayed in loop mode.
- The `seekTo` method works only when the playback speed is 1.0, and it sets the video position to the nearest keyframe, not the exact value passed.
-
- The `setLooping` method only works when the player's DataSourceType is DataSourceType.asset.
2 changes: 1 addition & 1 deletion packages/video_player_avplay/tizen/src/plus_player.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ bool PlusPlayer::Pause() {

bool PlusPlayer::SetLooping(bool is_looping) {
LOG_ERROR("[PlusPlayer] Not support to set looping.");
return false;
return true;
}

bool PlusPlayer::SetVolume(double volume) {
Expand Down
Loading