[video_player_videohole] Merge media player code from avplay #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSUYA
reviewed
Dec 15, 2023
There was a problem hiding this comment.
I left a few comments.
+)
in video_player_tizen.dart, wrong comment
- /// Pigeon-generated [TizenVideoPlayerApi].
+ /// Pigeon-generated [VideoPlayerVideoholeApi].
+)
In packages/video_player_videohole/pubspec.yaml.
ffi package dependency does not seem to be needed any more. Do we need it?
packages/video_player_videohole/tizen/src/video_player_tizen_plugin.cc
Outdated
Show resolved
Hide resolved
I have removed ffi package and modify video_player_tizen.dart |
JSUYA
approved these changes
Dec 19, 2023
hyue7
approved these changes
Dec 19, 2023
mhoeckner
added a commit
to mhoeckner/plugins
that referenced
this pull request
Dec 27, 2023
[video_player_videohole] Merge media player code from avplay (flutter-tizen#639)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still third-party using the video_player_videohole plugin because they are not partner. Compared to avplay, video_player_videohole's code is older, so merege media player code from avplay.