Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview_flutter_lwe] Update webivew_flutter to 4.4.2 #633

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

Swanseo0
Copy link
Contributor

  • Update webivew_flutter to 4.4.2.
  • Update webview_flutter_platform_interface to 2.6.0.
  • Update integration_test.
  • Add pub topics to package metadata.
  • Add support to retrieve the user agent. See LweWebViewController.getUserAgent.
  • Apply Platform API change.
  • Increase the minimum Flutter version to 3.3.

@Swanseo0 Swanseo0 force-pushed the webview_flutter_lwe branch from 175252e to 98f0111 Compare November 23, 2023 01:47
@Swanseo0 Swanseo0 marked this pull request as ready for review November 23, 2023 02:15
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check about onUrlChange added in webview_flutter v4.1.0?
The latest webview_flutter example code uses this API.

* Adds support to track URL changes. See `NavigationDelegate(onUrlChange)`.

@Swanseo0
Copy link
Contributor Author

Can you check about onUrlChange added in webview_flutter v4.1.0? The latest webview_flutter example code uses this API.

* Adds support to track URL changes. See `NavigationDelegate(onUrlChange)`.

Upon updating webview_flutter to 4.4.2, it was checked whether the added functions (onUrlChange, onConsoleMessage) are supported by LWE, but it was confirmed that there is no related function.

@JSUYA
Copy link
Member

JSUYA commented Nov 29, 2023

Can you check about onUrlChange added in webview_flutter v4.1.0? The latest webview_flutter example code uses this API.

* Adds support to track URL changes. See `NavigationDelegate(onUrlChange)`.

Upon updating webview_flutter to 4.4.2, it was checked whether the added functions (onUrlChange, onConsoleMessage) are supported by LWE, but it was confirmed that there is no related function.

Yes, you can add UnimplementedError to LweNavigationDelegate for onUrlChange.

@override
  Future<void> setOnUrlChange(UrlChangeCallback onUrlChange) async {
    throw UnimplementedError(
        'This version of `LweWebViewController` currently has no '
        'implementation of `setOnUrlChange`.');
  }

@JSUYA JSUYA merged commit 8af84b9 into flutter-tizen:master Dec 4, 2023
6 checks passed
mhoeckner pushed a commit to mhoeckner/plugins that referenced this pull request Dec 6, 2023
mhoeckner pushed a commit to mhoeckner/plugins that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants