Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-platform thread issue. #622

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Fix non-platform thread issue. #622

merged 5 commits into from
Oct 31, 2023

Conversation

hyue7
Copy link
Collaborator

@hyue7 hyue7 commented Oct 24, 2023 •
edited
Loading

fix issue in video_player and video_player_videohole:

[E] [ERROR:flutter/shell/common/shell.cc(1004)] The 'flutter.io/videoPlayer/videoEvents2' channel sent a message from native to Flutter on a non-platform thread. Platform channel messages must be sent on the platform thread. Failure to do so may result in data  loss or crashes, and must be fixed in the plugin or application code creating that channel.
See https://docs.flutter.dev/platform-integration/platform-channels#channels-and-platform-threading for  more information. [E]

swift-kim
swift-kim reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me. I'm afraid other plugins may have similar issues.

packages/video_player/tizen/src/video_player.cc Outdated Show resolved Hide resolved
packages/video_player/tizen/src/video_player.cc Outdated Show resolved Hide resolved
packages/video_player/tizen/src/video_player.cc Outdated Show resolved Hide resolved
@hyue7 hyue7 changed the title [video_player] Fix non-platform thread issue. Fix non-platform thread issue. Oct 26, 2023
@swift-kim swift-kim merged commit 045c9a0 into flutter-tizen:master Oct 31, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaowei-guan xiaowei-guan xiaowei-guan approved these changes

@swift-kim swift-kim swift-kim approved these changes

Assignees
No one assigned
Labels
p: video_player_videohole p: video_player
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyue7 @swift-kim @xiaowei-guan