Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup confirm stripe web #1989

Merged
merged 18 commits into from
Nov 17, 2024
Merged

Setup confirm stripe web #1989

merged 18 commits into from
Nov 17, 2024

Conversation

cedvdb
Copy link
Contributor

@cedvdb cedvdb commented Nov 7, 2024

This effectively adds setup intent support for any kind of payment method.

This adds ConfirmSetup to stripe web as confirmSetupIntent is deprecated. I used [ConfirmPayment] as a template to follow the conventions of this package.

An example was added (and the old one removed)

@cedvdb cedvdb changed the title Setup confirm [Draft] Setup confirm Nov 7, 2024
@cedvdb cedvdb changed the title [Draft] Setup confirm [Draft] Setup confirm stripe web Nov 7, 2024
@cedvdb cedvdb changed the title [Draft] Setup confirm stripe web Setup confirm stripe web Nov 7, 2024
@cedvdb
Copy link
Contributor Author

cedvdb commented Nov 7, 2024

@remonh87 This is now ready for review

@cedvdb
Copy link
Contributor Author

cedvdb commented Nov 7, 2024

integration tests failing because of

StripeCore/STPAPIClient.swift:150: Fatal error: You must use a valid publishable key. For more info, see https://stripe.com/docs/keys

@remonh87 remonh87 self-requested a review November 9, 2024 17:48
Copy link
Member

@remonh87 remonh87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look at the 2 minor comments but for the rest it looks good! thanks for contributing!

example/server/src/index.ts Outdated Show resolved Hide resolved
packages/stripe_web/CHANGELOG.md Outdated Show resolved Hide resolved
@remonh87 remonh87 merged commit 7a5bb7e into flutter-stripe:main Nov 17, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants