Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android payment sheet shapes not rendering correct when using double type #1933

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/stripe_platform_interface/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 11.1.1
- BREAKING: Changed payment sheet appearance related variables to use `int` instead of `double` to support android rendering.
- Support for PaymentSheetPrimaryButtonShape's added borderRadius added Android.

## 11.1.0
- Sync with Stripe [0.38.6](https://github.com/stripe/stripe-react-native/releases/tag/v0.38.6).
- Minor fixes and improvements.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,10 @@ class PaymentSheetShape with _$PaymentSheetShape {
@JsonSerializable(explicitToJson: true)
const factory PaymentSheetShape({
/// Borderradius for the paymentsheet corners
double? borderRadius,
int? borderRadius,

/// Borderwidth for the paymentsheet components
double? borderWidth,
int? borderWidth,

/// Appearance config of the payment sheet shadow
PaymentSheetShadowParams? shadow,
Expand Down Expand Up @@ -338,10 +338,10 @@ class PaymentSheetShadowOffset with _$PaymentSheetShadowOffset {
@JsonSerializable(explicitToJson: true)
const factory PaymentSheetShadowOffset({
/// X value
double? x,
int? x,

/// Y value
double? y,
int? y,
}) = _PaymentSheetShadowOffset;

factory PaymentSheetShadowOffset.fromJson(Map<String, dynamic> json) =>
Expand Down Expand Up @@ -373,10 +373,13 @@ class PaymentSheetPrimaryButtonShape with _$PaymentSheetPrimaryButtonShape {
PaymentSheetShadowParams? shadow,

/// the blur radius of the button
double? blurRadius,
int? blurRadius,

/// the border radius of the button
int? borderRadius,

/// border width of the primary button on the payment sheet
double? borderWidth,
int? borderWidth,
}) = _PaymentSheetPrimaryButtonShape;

factory PaymentSheetPrimaryButtonShape.fromJson(Map<String, dynamic> json) =>
Expand Down
Loading
Loading