fix projectPath string context flakes #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaggacao
force-pushed
the
fix-projectPath-string-context-flakes
branch
from
e2aa78b to
6cef42e
Compare
- `self.sourceInfo.outPath` brings a string context with it - Drop it for this pattern to work - Idempotent noop in non-flake scenario fixes: fluidattacks#577 (has more context)
blaggacao
force-pushed
the
fix-projectPath-string-context-flakes
branch
from
6cef42e to
98944cc
Compare
kamadorueda
reviewed
Sep 18, 2021
kamadorueda
reviewed
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.sourceInfo.outPathbrings a string context with itfixes: #577 (has more context)
Appreciation to the really helpful support on matrix from