Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for draining publish events before shutting down. #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nathanielc
Copy link

This change does two things:

  1. Adds logic to drain rx_io_requests on shutdown, this ensures that all outgoing requests to the MQTT broken are processed by the IoTask before the task is shutdown.
  2. Changes the behavior of a zero read from the client. A zero read does not indicate a disconnect from the broker and so this change simply ignores zero reads and continues processing.

I have been using these changes locally for a few weeks without issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant