Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HostAliases support to Fluent Bit and Fluentd specifications #1413

Merged

Conversation

MioOgbeni
Copy link
Contributor

What this PR does / why we need it:

Hi, I need to have option to set HostAliases into FluentD and FluentBit pods, so I decided to add this option directly to the operator for everyone. :)

Which issue(s) this PR fixes:

None

Does this PR introduced a user-facing change?

- HostAliases can be now passed into FluentD and FluentBit Pods.

Additional documentation, usage docs, etc.:


Copy link
Collaborator

@jjsiv jjsiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run make generate?

@MioOgbeni
Copy link
Contributor Author

MioOgbeni commented Nov 23, 2024

Hey, no problem. Previously I edited the CRD and setup manifests manually, but now I also generated them via make manifests, so now they are correctly autogenerated.

But when I do make generate, the only change is the removal of this constraints in all zz_generated.deepcopy files. Is this a required change @jjsiv? It doesn't relate to my changes, but to the go version (I'm using go1.22.9)

@jjsiv
Copy link
Collaborator

jjsiv commented Nov 23, 2024

Ok, that's good. The make generate should also update the generated DeepCopy functions for with the new HostAliases field
https://github.com/fluent/fluent-operator/blob/master/apis/fluentbit/v1alpha2/zz_generated.deepcopy.go#L955

@MioOgbeni
Copy link
Contributor Author

Oh, yes. I haven't checked all the files, but the one you mentioned and the same one for FluentD contain DeepCopy functions with the HostAliases field.

I commited it now @jjsiv ;)

@benjaminhuo benjaminhuo merged commit c9150cd into fluent:master Nov 26, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants