Support communicating with multiple admin sockets when nbprocs>1 #30

norrs · 2015-08-04T20:01:57Z

This is rebased on top of PR #29

This code is provided as is with no guarantees.

librhapr breaking changes:

rhapr interface has changed, send(message) is now send(message, process=1) so it can pass on which process id to try to look up for a socket.

in rhapr environment module:
socket_path is renamed to socket_paths and now returns an hash for socket paths , keyed on process id's. It still throws an runtime exception if no socket is found. A future enhancement might be to let it return an empty hash and let the client code which uses the library figure out what to do if it doesn't find any admin sockets.
socket now accepts an argument for the parameter process.

haproxyctl binary accepts the parameter -p where the argument has to be numeric identifier for the process id. if nbprocs > 1 , 0 means talking to every socket it finds.

Known bugs:
Regex doesn't skip #comments in file, so if you "redefine" the admin socket in a comment below the original comment, it will sadly overwrite it in the internal hash map.

Example outputs:

with nbprocs > 1

[root@a7504fbfa532 source]#  ./bin/haproxyctl -p1 show pools
Dumping pools usage. Use SIGQUIT to flush them.
  - Pool pipe (32 bytes) : 5 allocated (160 bytes), 5 used, 3 users [SHARED]
  - Pool capture (64 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
  - Pool channel (80 bytes) : 2 allocated (160 bytes), 2 used, 1 users [SHARED]
  - Pool task (112 bytes) : 24 allocated (2688 bytes), 24 used, 1 users [SHARED]
  - Pool uniqueid (128 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
  - Pool connection (320 bytes) : 2 allocated (640 bytes), 2 used, 1 users [SHARED]
  - Pool hdr_idx (416 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
  - Pool session (864 bytes) : 1 allocated (864 bytes), 1 used, 1 users [SHARED]
  - Pool requri (1024 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
  - Pool buffer (16416 bytes) : 2 allocated (32832 bytes), 2 used, 1 users [SHARED]
Total: 10 pools, 37344 bytes allocated, 37344 used.

[root@a7504fbfa532 source]#  ./bin/haproxyctl -p0 show pools
1: Dumping pools usage. Use SIGQUIT to flush them.
1:   - Pool pipe (32 bytes) : 5 allocated (160 bytes), 5 used, 3 users [SHARED]
1:   - Pool capture (64 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
1:   - Pool channel (80 bytes) : 2 allocated (160 bytes), 2 used, 1 users [SHARED]
1:   - Pool task (112 bytes) : 24 allocated (2688 bytes), 24 used, 1 users [SHARED]
1:   - Pool uniqueid (128 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
1:   - Pool connection (320 bytes) : 2 allocated (640 bytes), 2 used, 1 users [SHARED]
1:   - Pool hdr_idx (416 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
1:   - Pool session (864 bytes) : 1 allocated (864 bytes), 1 used, 1 users [SHARED]
1:   - Pool requri (1024 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
1:   - Pool buffer (16416 bytes) : 2 allocated (32832 bytes), 2 used, 1 users [SHARED]
1: Total: 10 pools, 37344 bytes allocated, 37344 used.
1: 
2: Dumping pools usage. Use SIGQUIT to flush them.
2:   - Pool pipe (32 bytes) : 5 allocated (160 bytes), 5 used, 3 users [SHARED]
2:   - Pool capture (64 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
2:   - Pool channel (80 bytes) : 2 allocated (160 bytes), 2 used, 1 users [SHARED]
2:   - Pool task (112 bytes) : 24 allocated (2688 bytes), 24 used, 1 users [SHARED]
2:   - Pool uniqueid (128 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
2:   - Pool connection (320 bytes) : 2 allocated (640 bytes), 2 used, 1 users [SHARED]
2:   - Pool hdr_idx (416 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
2:   - Pool session (864 bytes) : 1 allocated (864 bytes), 1 used, 1 users [SHARED]
2:   - Pool requri (1024 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
2:   - Pool buffer (16416 bytes) : 2 allocated (32832 bytes), 2 used, 1 users [SHARED]
2: Total: 10 pools, 37344 bytes allocated, 37344 used.
2: 
3: Dumping pools usage. Use SIGQUIT to flush them.
3:   - Pool pipe (32 bytes) : 5 allocated (160 bytes), 5 used, 3 users [SHARED]
3:   - Pool capture (64 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
3:   - Pool channel (80 bytes) : 2 allocated (160 bytes), 2 used, 1 users [SHARED]
3:   - Pool task (112 bytes) : 24 allocated (2688 bytes), 24 used, 1 users [SHARED]
3:   - Pool uniqueid (128 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
3:   - Pool connection (320 bytes) : 2 allocated (640 bytes), 2 used, 1 users [SHARED]
3:   - Pool hdr_idx (416 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
3:   - Pool session (864 bytes) : 1 allocated (864 bytes), 1 used, 1 users [SHARED]
3:   - Pool requri (1024 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
3:   - Pool buffer (16416 bytes) : 2 allocated (32832 bytes), 2 used, 1 users [SHARED]
3: Total: 10 pools, 37344 bytes allocated, 37344 used.
3: 
4: Dumping pools usage. Use SIGQUIT to flush them.
4:   - Pool pipe (32 bytes) : 5 allocated (160 bytes), 5 used, 3 users [SHARED]
4:   - Pool capture (64 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
4:   - Pool channel (80 bytes) : 2 allocated (160 bytes), 2 used, 1 users [SHARED]
4:   - Pool task (112 bytes) : 24 allocated (2688 bytes), 24 used, 1 users [SHARED]
4:   - Pool uniqueid (128 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
4:   - Pool connection (320 bytes) : 2 allocated (640 bytes), 2 used, 1 users [SHARED]
4:   - Pool hdr_idx (416 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
4:   - Pool session (864 bytes) : 1 allocated (864 bytes), 1 used, 1 users [SHARED]
4:   - Pool requri (1024 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
4:   - Pool buffer (16416 bytes) : 2 allocated (32832 bytes), 2 used, 1 users [SHARED]
4: Total: 10 pools, 37344 bytes allocated, 37344 used.
4: 
5: Dumping pools usage. Use SIGQUIT to flush them.
5:   - Pool pipe (32 bytes) : 5 allocated (160 bytes), 5 used, 3 users [SHARED]
5:   - Pool capture (64 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
5:   - Pool channel (80 bytes) : 2 allocated (160 bytes), 2 used, 1 users [SHARED]
5:   - Pool task (112 bytes) : 24 allocated (2688 bytes), 24 used, 1 users [SHARED]
5:   - Pool uniqueid (128 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
5:   - Pool connection (320 bytes) : 2 allocated (640 bytes), 2 used, 1 users [SHARED]
5:   - Pool hdr_idx (416 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
5:   - Pool session (864 bytes) : 1 allocated (864 bytes), 1 used, 1 users [SHARED]
5:   - Pool requri (1024 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
5:   - Pool buffer (16416 bytes) : 2 allocated (32832 bytes), 2 used, 1 users [SHARED]
5: Total: 10 pools, 37344 bytes allocated, 37344 used.
5: 
6: Dumping pools usage. Use SIGQUIT to flush them.
6:   - Pool pipe (32 bytes) : 5 allocated (160 bytes), 5 used, 3 users [SHARED]
6:   - Pool capture (64 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
6:   - Pool channel (80 bytes) : 2 allocated (160 bytes), 2 used, 1 users [SHARED]
6:   - Pool task (112 bytes) : 24 allocated (2688 bytes), 24 used, 1 users [SHARED]
6:   - Pool uniqueid (128 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
6:   - Pool connection (320 bytes) : 2 allocated (640 bytes), 2 used, 1 users [SHARED]
6:   - Pool hdr_idx (416 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
6:   - Pool session (864 bytes) : 1 allocated (864 bytes), 1 used, 1 users [SHARED]
6:   - Pool requri (1024 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
6:   - Pool buffer (16416 bytes) : 2 allocated (32832 bytes), 2 used, 1 users [SHARED]
6: Total: 10 pools, 37344 bytes allocated, 37344 used.
6:

With nbprocs < 2

[root@6c7b51b85ac6 source]# ./haproxyctl show info -p1
/source/bin/../lib/haproxyctl.rb:94:in `unixsock': Could not find a stats socket with process 1 in /etc/haproxy/haproxy.cfg (RuntimeError)
    from ./haproxyctl:195
[root@6c7b51b85ac6 source]# ./haproxyctl show info -p0
Name: HAProxy
Version: 1.5.2
Release_date: 2014/07/12
Nbproc: 1
Process_num: 1
Pid: 23
Uptime: 0d 0h13m33s
Uptime_sec: 813
Memmax_MB: 0
Ulimit-n: 8036
Maxsock: 8036
Maxconn: 4000
Hard_maxconn: 4000
CurrConns: 0
CumConns: 4
CumReq: 4
MaxSslConns: 0
CurrSslConns: 0
CumSslConns: 0
Maxpipes: 0
PipesUsed: 0
PipesFree: 0
ConnRate: 0
ConnRateLimit: 0
MaxConnRate: 0
SessRate: 0
SessRateLimit: 0
MaxSessRate: 0
SslRate: 0
SslRateLimit: 0
MaxSslRate: 0
SslFrontendKeyRate: 0
SslFrontendMaxKeyRate: 0
SslFrontendSessionReuse_pct: 0
SslBackendKeyRate: 0
SslBackendMaxKeyRate: 0
SslCacheLookups: 0
SslCacheMisses: 0
CompressBpsIn: 0
CompressBpsOut: 0
CompressBpsRateLim: 0
ZlibMemUsage: 0
MaxZlibMemUsage: 0
Tasks: 11
Run_queue: 1
Idle_pct: 100
node: 6c7b51b85ac6
description: 

# Without the -p parameter as well when nbprocs < 2
[root@bcdb5ee693d1 source]# ./haproxyctl show pools
Dumping pools usage. Use SIGQUIT to flush them.
  - Pool pipe (32 bytes) : 5 allocated (160 bytes), 5 used, 3 users [SHARED]
  - Pool capture (64 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
  - Pool channel (80 bytes) : 2 allocated (160 bytes), 2 used, 1 users [SHARED]
  - Pool task (112 bytes) : 11 allocated (1232 bytes), 11 used, 1 users [SHARED]
  - Pool uniqueid (128 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
  - Pool connection (320 bytes) : 2 allocated (640 bytes), 2 used, 1 users [SHARED]
  - Pool hdr_idx (416 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
  - Pool session (864 bytes) : 1 allocated (864 bytes), 1 used, 1 users [SHARED]
  - Pool requri (1024 bytes) : 0 allocated (0 bytes), 0 used, 1 users [SHARED]
  - Pool buffer (16416 bytes) : 2 allocated (32832 bytes), 2 used, 1 users [SHARED]
Total: 10 pools, 35888 bytes allocated, 35888 used.

[root@1cfa2370b6cf source]# ./haproxyctl -p4 set weight backend/node01 40

[root@1cfa2370b6cf source]# ./haproxyctl -p0 get weight backend/node01 
1: 60 (initial 60)
1: 
2: 60 (initial 60)
2: 
3: 60 (initial 60)
3: 
4: 40 (initial 60)
4: 
5: 60 (initial 60)
5: 
6: 60 (initial 60)
6:

…ecated

…ets on nbprocs>1

…rks.

norrs · 2015-08-05T11:17:29Z

I'm still working on fixing a few bugs when it comes to using -p 0 and nbprocs > 1 to ensure output always follows the dsh formatting.

dsh_output is true if nbprocs > 1 and process is 0 which means targeting every socket it finds.

norrs · 2015-08-05T12:39:01Z

This should work better. :-)

Input means talking to haproxy admin socket, and where functions fetch something valuable from the first data row. (as dsh_output prefixes output with process id)

Roy Sindre Norangshol added 9 commits August 4, 2015 13:04

File.stub! is deprecated for File.stub

f2e7b81

Fixing deprecated 'and_return { value }'

9b941cf

use === equality check and not only thrutiness. after be_true is depr…

001731e

…ecated

from rspec 3 test must be skipped and not pending for being skipped

09a3041

Regexp.last_match is a method, not an array

e84466d

Support multiple admin sockets when nbprocs>1 in rhapr

30953c8

Support multiple admin sockets when nbprocs>1 in binary

f07b024

Keep dsh output format only for when communicating with multiple sock…

b7ab85b

…ets on nbprocs>1

Flatten output - don't want nested structures so .grep() etc still wo…

36100c8

…rks.

Send proper arguments when dsh_output.

62e42eb

dsh_output is true if nbprocs > 1 and process is 0 which means targeting every socket it finds.

norrs mentioned this pull request Aug 6, 2015

Support multiple admin sockets when nbprocs > 1 zedge/haproxyctl#1

Merged

Roy Sindre Norangshol added 2 commits August 10, 2015 13:27

Strip extra whitespace before first word(command)

964042e

Don't special case data[0] for output, only required for input

de2ef47

Input means talking to haproxy admin socket, and where functions fetch something valuable from the first data row. (as dsh_output prefixes output with process id)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support communicating with multiple admin sockets when nbprocs>1 #30

Support communicating with multiple admin sockets when nbprocs>1 #30

norrs commented Aug 4, 2015

norrs commented Aug 5, 2015

norrs commented Aug 5, 2015

Support communicating with multiple admin sockets when nbprocs>1 #30

Are you sure you want to change the base?

Support communicating with multiple admin sockets when nbprocs>1 #30

Conversation

norrs commented Aug 4, 2015

norrs commented Aug 5, 2015

norrs commented Aug 5, 2015