Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ui_dbg.h with ImGUI API change on Keyboard #102

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Mokona
Copy link
Contributor

@Mokona Mokona commented Oct 1, 2024

Change the deprecated CaptureKeyboardFromApp() that is now removed from ImGUI to SetNextFrameWantCaptureKeyboard(true) (see comments in imgui.cpp for 1.90.7 revision)

@Mokona
Copy link
Contributor Author

Mokona commented Oct 1, 2024

Checks have failed on the CaptureKeyboardFromApp() not existing... is the GitHub workflow getting the actual PR content, or the main branch?

Or don't I see something obvious?

@floooh
Copy link
Owner

floooh commented Oct 2, 2024

It's using the wrapper project here which has imgui as submodule currently pinned to 1.91.1:

https://github.com/fips-libs/fips-imgui

I'll check if updating to the latest imgui version tag causes any other issues, if not I'll simply update fips-imgui. If the breaking change is only in the head version I'd like to wait until the next imgui release though.

@floooh
Copy link
Owner

floooh commented Oct 2, 2024

Hmm strange, SetNextFrameWantCaptureKeyboard already exists in 1.91.1, investigating...

PS: wait, it's about the old function not existing...

@floooh
Copy link
Owner

floooh commented Oct 2, 2024

Ah ok, the old function was already removed in 1.91.1, but I guess I forgot checking if the emulators actually still build... I'm not sure why GH Actions is trying to build a version that doesn't include your fix though. Let me check a couple of things and then I'll merge your PR one sec.

@floooh
Copy link
Owner

floooh commented Oct 2, 2024

Ok, confirmed that the chips master branch doesn't currently build. I should have checked that after updating to imgui 1.91.1, but obviously forgot :/

@floooh floooh merged commit 247ad89 into floooh:master Oct 2, 2024
0 of 4 checks passed
@floooh
Copy link
Owner

floooh commented Oct 2, 2024

Ok, your fix works fine and merged, thanks! I guess the Github CI pipeline for PRs gets confused when the master/main branch doesn't currently build.

@Mokona
Copy link
Contributor Author

Mokona commented Oct 2, 2024

Thanks for the merge.

@Mokona Mokona deleted the fix-for-imgui branch October 2, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants