Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TLS handshake issue in ingress #69

Merged

Conversation

addozhang
Copy link
Collaborator

Description:

Fix the issue occurred during TLS handshake.

Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [x]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)?

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (d77f3d6) 48.60% compared to head (0de3076) 48.57%.

❗ Current head 0de3076 differs from pull request most recent head f28e1c0. Consider uploading reports for the commit f28e1c0 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.1      #69      +/-   ##
================================================
- Coverage         48.60%   48.57%   -0.04%     
================================================
  Files               194      194              
  Lines             14477    14477              
================================================
- Hits               7037     7032       -5     
- Misses             7397     7402       +5     
  Partials             43       43              
Flag Coverage Δ
unittests 48.57% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reaver-flomesh reaver-flomesh merged commit 15a6711 into flomesh-io:release/v1.1 Sep 14, 2023
26 checks passed
@reaver-flomesh reaver-flomesh added the bug Something isn't working label Sep 14, 2023
@reaver-flomesh reaver-flomesh added this to the v1.1.1 milestone Sep 14, 2023
@reaver-flomesh reaver-flomesh changed the title Fix TLS handshake issue in ingress fix: TLS handshake issue in ingress Sep 14, 2023
@addozhang addozhang deleted the release/v1.1-patch branch September 15, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants