Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init nebula-grpc connector with zookeeper. #513

Merged

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Dec 11, 2024

Description:
Init nebula-grpc connector with zookeeper.

Testing done:
Done

Affected area:

Functional Area
New Functionality [X]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0.13643% with 2196 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.5@01887c7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/zookeeper/discovery/nebula/urlenc/urlenc.go 0.00% 422 Missing ⚠️
pkg/zookeeper/discovery/nebula/mapfield.go 0.00% 296 Missing ⚠️
pkg/zookeeper/client.go 0.00% 282 Missing ⚠️
pkg/connector/provider/zookeeper.go 0.00% 235 Missing ⚠️
...g/apis/connector/v1alpha1/zz_generated.deepcopy.go 0.00% 169 Missing ⚠️
pkg/zookeeper/discovery/nebula/instance.go 0.00% 91 Missing ⚠️
pkg/connector/ktog/gateway.go 0.00% 89 Missing ⚠️
...connector/v1alpha1/fake/fake_zookeeperconnector.go 0.00% 69 Missing ⚠️
pkg/connector/discovery.go 0.00% 63 Missing ⚠️
pkg/connector/cli/config.go 0.00% 62 Missing ⚠️
... and 26 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.5     #513   +/-   ##
===============================================
  Coverage                ?   15.01%           
===============================================
  Files                   ?      841           
  Lines                   ?    61896           
  Branches                ?        0           
===============================================
  Hits                    ?     9291           
  Misses                  ?    52429           
  Partials                ?      176           
Flag Coverage Δ
unittests 15.01% <0.13%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reaver-flomesh reaver-flomesh added area/connector Task/Issue related to cloud connector change/go Pull requests that update Go code kind/enhancement New feature or request size/M 7 days (~1.5 week) priority/P1 P1 priority labels Dec 11, 2024
@reaver-flomesh reaver-flomesh added this to the v1.5.0 milestone Dec 11, 2024
Copy link

✅ PR Title Formatted Correctly

The title of this PR has been updated to match the correct format. Thank you!

@reaver-flomesh reaver-flomesh merged commit fd2e414 into flomesh-io:release/v1.5 Dec 11, 2024
43 checks passed
reaver-flomesh pushed a commit that referenced this pull request Dec 11, 2024
@cybwan cybwan deleted the release/v1.5.0-alpha.4 branch December 11, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connector Task/Issue related to cloud connector change/go Pull requests that update Go code kind/enhancement New feature or request priority/P1 P1 priority size/M 7 days (~1.5 week)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants