Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SidecarTimeout to MeshConfig. #35

Merged
merged 6 commits into from
Sep 3, 2023
Merged

Add SidecarTimeout to MeshConfig. #35

merged 6 commits into from
Sep 3, 2023

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Sep 2, 2023

Description:
Add SidecarTimeout to MeshConfig.

Testing done:
Done

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 6.66% and project coverage change: -0.14% ⚠️

Comparison is base (cd40e30) 52.68% compared to head (1622b82) 52.54%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   52.68%   52.54%   -0.14%     
==========================================
  Files         175      175              
  Lines       12804    12819      +15     
==========================================
- Hits         6746     6736      -10     
- Misses       6027     6052      +25     
  Partials       31       31              
Flag Coverage Δ
unittests 52.54% <6.66%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/configurator/methods.go 24.34% <0.00%> (-0.39%) ⬇️
pkg/configurator/mock_client_generated.go 0.00% <0.00%> (ø)
pkg/messaging/broker.go 65.09% <100.00%> (-2.20%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reaver-flomesh reaver-flomesh added the enhancement New feature or request label Sep 3, 2023
@reaver-flomesh reaver-flomesh added this to the v1.1.1 milestone Sep 3, 2023
@reaver-flomesh reaver-flomesh merged commit 62c76d0 into flomesh-io:main Sep 3, 2023
26 checks passed
@cybwan cybwan deleted the release-v1.0.2-alpha.1 branch September 4, 2023 00:21
reaver-flomesh pushed a commit that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants