Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying sidecar's image for pod and namespace. #327

Merged

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Aug 14, 2024

…tation for pod and namespace.

Description:
Support specifying sidecar's image by "flomesh.io/sidecar-image" annotation for pod and namespace.

Testing done:

Affected area:

Functional Area
New Functionality [X]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

@reaver-flomesh reaver-flomesh added the enhancement New feature or request label Aug 14, 2024
@reaver-flomesh reaver-flomesh added this to the v1.3.8 milestone Aug 14, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 14.46%. Comparing base (cf56380) to head (d993876).
Report is 111 commits behind head on release/v1.3.

Files Patch % Lines
...kg/sidecar/providers/pipy/driver/pipy_container.go 0.00% 13 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/v1.3     #327       +/-   ##
=================================================
- Coverage         46.81%   14.46%   -32.35%     
=================================================
  Files               199      760      +561     
  Lines             15239    51060    +35821     
=================================================
+ Hits               7134     7386      +252     
- Misses             8059    43505    +35446     
- Partials             46      169      +123     
Flag Coverage Δ
unittests 14.46% <0.00%> (-32.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reaver-flomesh reaver-flomesh merged commit 9a51e0a into flomesh-io:release/v1.3 Aug 14, 2024
27 checks passed
@cybwan cybwan deleted the release/v1.3.7-alpha.4 branch August 14, 2024 12:09
reaver-flomesh pushed a commit that referenced this pull request Aug 16, 2024
reaver-flomesh pushed a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants