Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix load balance endpoints registrations for connector. #322

Closed
wants to merge 12 commits into from

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Aug 7, 2024

Description:
fix load balance endpoints registrations for connector.

Testing done:
Done

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [x]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

@reaver-flomesh reaver-flomesh added the enhancement New feature or request label Aug 7, 2024
@reaver-flomesh reaver-flomesh added this to the v1.3.8 milestone Aug 7, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 122 lines in your changes missing coverage. Please review.

Project coverage is 14.44%. Comparing base (cf56380) to head (591e23c).
Report is 110 commits behind head on release/v1.3.

Files Patch % Lines
pkg/connector/ctok/syncer.go 0.00% 58 Missing ⚠️
pkg/connector/ctok/job.go 0.00% 38 Missing ⚠️
pkg/connector/ktoc/source.go 0.00% 7 Missing ⚠️
pkg/connector/provider/eureka.go 0.00% 5 Missing ⚠️
pkg/connector/cli/flags.go 0.00% 4 Missing ⚠️
cmd/fsm-connector/fsm-connector.go 0.00% 3 Missing ⚠️
pkg/connector/cache.go 0.00% 2 Missing ⚠️
pkg/connector/ctok/endpoint.go 0.00% 2 Missing ⚠️
pkg/connector/provider/nacos.go 0.00% 2 Missing ⚠️
pkg/connector/cli/sync.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/v1.3     #322       +/-   ##
=================================================
- Coverage         46.81%   14.44%   -32.37%     
=================================================
  Files               199      761      +562     
  Lines             15239    51136    +35897     
=================================================
+ Hits               7134     7388      +254     
- Misses             8059    43579    +35520     
- Partials             46      169      +123     
Flag Coverage Δ
unittests 14.44% <0.00%> (-32.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cybwan cybwan closed this Aug 7, 2024
@cybwan cybwan deleted the release/v1.3.7 branch August 7, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants