Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy random integration #622

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

numpy random integration #622

wants to merge 11 commits into from

Conversation

trbritt
Copy link
Collaborator

@trbritt trbritt commented Jun 23, 2023

This is the complete integration of the Numpy Random submodule from beginning to end.

Documentation: flojoy-ai/docs#124
Nodes: flojoy-ai/nodes#135
Python: flojoy-ai/python#45

Bug improvement:
While we have retained style conventions for how the manifest.yaml files should be written, autogenerating these nodes and the respective manifests have highlighted that studio is really sensitive to this formatting, and cannot boot successfully should things like tabs be \t and not spaces. I have implemented safer loading for all places where the yamls are needed (for example in the documentation generation, in generate_manfests.py, etc, to implement some sort of userproofing, to ensure user-generated manifests (that may not remember to keep the formatting) can still be recognized.

@trbritt trbritt requested a review from smahmed776 June 23, 2023 15:34
@yassine-moumen
Copy link
Contributor

To access Flojoy-studio build from this pull request, you can use the following URLs:

Windows installation: http://622_windows.flojoy-test.com:3000
Linux installation: http://622_linux.flojoy-test.com:3000

Please note that it may take a few minutes for the instance to start up, so please be patient.

It is important to know that the instance will automatically shut down after 4 hours to conserve resources. If you wish to start the instance again after it shuts down (or restart it to pickup new changes), you can use this API :

Windows: https://kgpsoscpc4q52d4mtwuu7jhvie0qdiso.lambda-url.us-east-1.on.aws/start_instance?instance_id=i-05073547ac7c58ff4&domain=622_windows

Linux: https://kgpsoscpc4q52d4mtwuu7jhvie0qdiso.lambda-url.us-east-1.on.aws/start_instance?instance_id=i-0282d8eb5c8172c18&domain=622_linux

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (65f5c40) 64.69% compared to head (c7fab41) 64.69%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #622   +/-   ##
========================================
  Coverage    64.69%   64.69%           
========================================
  Files           82       82           
  Lines         1841     1841           
  Branches       469      469           
========================================
  Hits          1191     1191           
  Misses         585      585           
  Partials        65       65           
Flag Coverage Δ
typescript 64.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/__tests__/__utils__/utils.tsx 100.00% <ø> (ø)
src/__tests__/config/CSSStub.js 100.00% <ø> (ø)
src/assets/ArithmeticSVG.tsx 78.57% <ø> (ø)
src/assets/CancelIcon.tsx 66.66% <ø> (ø)
src/assets/FamilyHistoryIconSVG.tsx 100.00% <ø> (ø)
src/assets/FlojoyTheme.ts 100.00% <ø> (ø)
src/assets/HistoryIconSVG.tsx 75.00% <ø> (ø)
src/assets/KeyboardIconSVG.tsx 75.00% <ø> (ø)
src/assets/LoadIconSVG.tsx 75.00% <ø> (ø)
src/assets/PlayBtnIconSVG.tsx 100.00% <ø> (ø)
... and 72 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jackparmer
Copy link
Collaborator

hey @trbritt

@JeffDotPng / @itsjoeoui / @mdasifhasan can fill you in more, but i believe that this week they are merging a change to the nodes API that among other things, will create stronger typing and allow for multiple node inputs and outputs

some details here
https://flowjoy.slack.com/archives/C03KH05RZLK/p1687563713367559

your autogeneration pipeline will have to be tweaked at that point, so we may just want this PR to sit until then

@jalium
Copy link

jalium commented Sep 6, 2023

hey @trbritt

@JeffDotPng / @itsjoeoui / @mdasifhasan can fill you in more, but i believe that this week they are merging a change to the nodes API that among other things, will create stronger typing and allow for multiple node inputs and outputs

some details here https://flowjoy.slack.com/archives/C03KH05RZLK/p1687563713367559

your autogeneration pipeline will have to be tweaked at that point, so we may just want this PR to sit until then

@smahmed776 Is this " change to the nodes API" complete?
@trbritt Should we move to resolve these conflicts and merge?

@smahmed776
Copy link
Member

smahmed776 commented Sep 6, 2023

hey @trbritt

@JeffDotPng / @itsjoeoui / @mdasifhasan can fill you in more, but i believe that this week they are merging a change to the nodes API that among other things, will create stronger typing and allow for multiple node inputs and outputs

some details here https://flowjoy.slack.com/archives/C03KH05RZLK/p1687563713367559

your autogeneration pipeline will have to be tweaked at that point, so we may just want this PR to sit until then

@smahmed776 Is this " change to the nodes API" complete?
@trbritt Should we move to resolve these conflicts and merge?

@jalium Yes the changes to node API is completed and are now in main branch.

@itsjoeoui itsjoeoui changed the base branch from develop to main October 25, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants