-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy random integration #622
base: main
Are you sure you want to change the base?
Conversation
To access Flojoy-studio build from this pull request, you can use the following URLs:Windows installation: http://622_windows.flojoy-test.com:3000 Please note that it may take a few minutes for the instance to start up, so please be patient. It is important to know that the instance will automatically shut down after 4 hours to conserve resources. If you wish to start the instance again after it shuts down (or restart it to pickup new changes), you can use this API : |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #622 +/- ##
========================================
Coverage 64.69% 64.69%
========================================
Files 82 82
Lines 1841 1841
Branches 469 469
========================================
Hits 1191 1191
Misses 585 585
Partials 65 65
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
hey @trbritt @JeffDotPng / @itsjoeoui / @mdasifhasan can fill you in more, but i believe that this week they are merging a change to the nodes API that among other things, will create stronger typing and allow for multiple node inputs and outputs some details here your autogeneration pipeline will have to be tweaked at that point, so we may just want this PR to sit until then |
@smahmed776 Is this " change to the nodes API" complete? |
@jalium Yes the changes to node API is completed and are now in main branch. |
This is the complete integration of the Numpy Random submodule from beginning to end.
Documentation: flojoy-ai/docs#124
Nodes: flojoy-ai/nodes#135
Python: flojoy-ai/python#45
Bug improvement:
While we have retained style conventions for how the
manifest.yaml
files should be written, autogenerating these nodes and the respective manifests have highlighted that studio is really sensitive to this formatting, and cannot boot successfully should things like tabs be\t
and not spaces. I have implemented safer loading for all places where theyamls
are needed (for example in the documentation generation, ingenerate_manfests.py
, etc, to implement some sort of userproofing, to ensure user-generated manifests (that may not remember to keep the formatting) can still be recognized.