Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STU-337] Cloud integration: Loading test profile #1156

Merged
merged 35 commits into from
Apr 16, 2024
Merged

[STU-337] Cloud integration: Loading test profile #1156

merged 35 commits into from
Apr 16, 2024

Conversation

LatentDream
Copy link
Member

@LatentDream LatentDream commented Apr 16, 2024 •
edited
Loading

Description

If a repo is specify with a Test Profile, provide the user with the ability to automatically load the all the sequences attached to this one.

  • Added a fix for the Upload (an Alias was missing for the conversion camelCase -> snake_case

TODO list

  • If URL is specify load the Test Profile
    • Viewer, will load automatically
    • Admin, will ask confirmation
  • Production Line -> Test Profile (to have the same name as the mock)
  • Viewer permission
  • Having an example with the default production line in Cloud

Some warning

  • Currently assume Git is installed
  • Private repo works only if the user has set git credential

To test

  1. Create a repo with a sequence(s) (.tjoy) saved at the root.
  2. Put the repo URL in the Test Profile in Cloud
  3. Select the Test Profile in the sequencer
  • Everything will be automatically loaded

@LatentDream LatentDream added ux ux design & implementation sequencer labels Apr 16, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 9:34pm

@LatentDream LatentDream marked this pull request as ready for review April 16, 2024 16:23
itsjoeoui
itsjoeoui requested changes Apr 16, 2024
View reviewed changes
src/renderer/lib/api.ts Show resolved Hide resolved
39bytes
39bytes reviewed Apr 16, 2024
View reviewed changes
captain/routes/test_profile.py Outdated Show resolved Hide resolved
captain/routes/test_profile.py Outdated Show resolved Hide resolved
captain/routes/test_profile.py Outdated Show resolved Hide resolved
src/main/utils.ts Outdated Show resolved Hide resolved
src/renderer/hooks/useTestSequencerProject.ts Outdated Show resolved Hide resolved
src/renderer/hooks/useTestSequencerState.ts Outdated Show resolved Hide resolved
src/renderer/hooks/useTestSequencerState.ts Outdated Show resolved Hide resolved
src/renderer/lib/api.ts Outdated Show resolved Hide resolved
LatentDream and others added 2 commits April 16, 2024 13:18
@LatentDream @39bytes
chore: fix typo
5dfb553 
Co-authored-by: Jeff Zhang <[email protected]>
@LatentDream @39bytes
chore: Nullish coalescing operator
929c518 
Co-authored-by: Jeff Zhang <[email protected]>
@LatentDream LatentDream requested a review from itsjoeoui April 16, 2024 21:51
itsjoeoui
itsjoeoui approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@itsjoeoui itsjoeoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@itsjoeoui itsjoeoui merged commit ffd0481 into flojoy-ai:main Apr 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@39bytes 39bytes 39bytes left review comments

@itsjoeoui itsjoeoui itsjoeoui approved these changes

Assignees
No one assigned
Labels
sequencer ux ux design & implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LatentDream @itsjoeoui @39bytes