Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snowflake block #1154

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

snowflake block #1154

wants to merge 4 commits into from

Conversation

izi-on
Copy link
Contributor

@izi-on izi-on commented Apr 12, 2024

quick question: is it normal that the dependencies specified in the flojoy decorator get added to [tool.poetry.dependencies] and not [tool.poetry.group.blocks.dependencies]?

Copy link

linear bot commented Apr 12, 2024

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 2:55pm

@izi-on izi-on requested review from LatentDream and itsjoeoui April 12, 2024 21:37

cursor = conn.cursor()
try:
query = f"SELECT * FROM {table_name}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

humm this is usually a pretty bad idea for obvious reasons :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsjoeoui look where the table names are fetched from, not a user input

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used anymore but thanks for letting me know

@LatentDream
Copy link
Member

LatentDream commented Apr 13, 2024

quick question: is it normal that the dependencies specified in the flojoy decorator get added to [tool.poetry.dependencies] and not [tool.poetry.group.blocks.dependencies]?

Huum good question, I'll take a look. It's not a breaking problem tho

@@ -38,6 +38,9 @@ nimodinst = "^1.4.7"
flojoy-cloud = "^0.1.3"
bcrypt = "^4.1.2"
tinymovr = "^1.6.5"
snowflake-connector-python = "3.8.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If specified in the "deps" let's not package it in

@@ -38,6 +38,9 @@ nimodinst = "^1.4.7"
flojoy-cloud = "^0.1.3"
bcrypt = "^4.1.2"
tinymovr = "^1.6.5"
snowflake-connector-python = "3.8.1"
langchain = "0.1.16"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one could be in the AI group

@izi-on
Copy link
Contributor Author

izi-on commented Apr 14, 2024

  • Convert poetry dep to @FloJoy(deps=[…])

@itsjoeoui
Copy link
Member

  • Convert poetry dep to @FloJoy(deps=[…])

CleanShot 2024-04-15 at 15 51 38
lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants