-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snowflake block #1154
base: main
Are you sure you want to change the base?
snowflake block #1154
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
cursor = conn.cursor() | ||
try: | ||
query = f"SELECT * FROM {table_name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
humm this is usually a pretty bad idea for obvious reasons :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsjoeoui look where the table names are fetched from, not a user input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used anymore but thanks for letting me know
Huum good question, I'll take a look. It's not a breaking problem tho |
@@ -38,6 +38,9 @@ nimodinst = "^1.4.7" | |||
flojoy-cloud = "^0.1.3" | |||
bcrypt = "^4.1.2" | |||
tinymovr = "^1.6.5" | |||
snowflake-connector-python = "3.8.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If specified in the "deps" let's not package it in
@@ -38,6 +38,9 @@ nimodinst = "^1.4.7" | |||
flojoy-cloud = "^0.1.3" | |||
bcrypt = "^4.1.2" | |||
tinymovr = "^1.6.5" | |||
snowflake-connector-python = "3.8.1" | |||
langchain = "0.1.16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one could be in the AI
group
|
|
quick question: is it normal that the dependencies specified in the flojoy decorator get added to [tool.poetry.dependencies] and not [tool.poetry.group.blocks.dependencies]?