[stu-343-edit-sequence-name-descriotion] chore: using Immer + remove …

…useless spread operation
flojoy-ai · Apr 15, 2024 · ff39d3e · ff39d3e
1 parent 0b5e84a
commit ff39d3e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/src/renderer/routes/test_sequencer_panel/components/data-table/SequenceTable.tsx b/src/renderer/routes/test_sequencer_panel/components/data-table/SequenceTable.tsx
@@ -273,18 +273,17 @@ export function SequenceTable() {
       toast.error("Sequence name must be unique");
       return;
     }
-    setSequences(
-      [...sequences].map((seq, idx) => {
-        if (idx === renameForIdx.current) {
-          return {
-            ...seq,
-            project: { ...seq.project, name: newName },
-            testSequenceUnsaved: true,
-          };
-        }
-        return seq;
-      }),
-    );
+    if (newName === "") {
+      toast.error("Sequence name cannot be empty");
+      return;
+    }
+    setSequences(produce(sequences, (draft) => {
+      const seq = draft[renameForIdx.current];
+      seq.project.name = newName;
+      seq.testSequenceUnsaved = true;
+    }))
+    setIsRenameDescModalOpen(false);
+
     setIsRenameNameModalOpen(false);
   };
   const [isRenameNameModalOpen, setIsRenameNameModalOpen] = useState(false);

diff --git a/src/renderer/routes/test_sequencer_panel/utils/SequenceHandler.ts b/src/renderer/routes/test_sequencer_panel/utils/SequenceHandler.ts
@@ -85,7 +85,7 @@ export async function saveSequence(
   }
   // Set the sequence as saved
   stateManager.setSequences(
-    [...stateManager.sequences].map((seq) => {
+    stateManager.sequences.map((seq) => {
       if (seq.project.name === sequence.name) {
         return { ...seq, testSequenceUnsaved: false };
       }
@@ -121,7 +121,7 @@ export async function saveSequences(
       return err(res.error);
     }
     stateManager.setSequences(
-      [...stateManager.sequences].map((seq) => ({
+      stateManager.sequences.map((seq) => ({
         ...seq,
         testSequenceUnsaved: false,
       })),