Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

TORCHSCRIPT_CLASSIFIER node for any user-provided .torchscript AI model #234

Merged
merged 24 commits into from
Sep 8, 2023
Merged

TORCHSCRIPT_CLASSIFIER node for any user-provided .torchscript AI model #234

merged 24 commits into from
Sep 8, 2023

Conversation

Roulbac
Copy link
Contributor

@Roulbac Roulbac commented Aug 14, 2023

Description

  • I've included a concise description of what each node does

Styleguide

  • My node adheres to the styleguide for Flojoy nodes

Docs

  • I've submitted a PR for a documentation page for the new node(s) that contains usage examples (see docs.flojoy.io)

Testing

  • This PR includes a unit test (example here and/or ideally a screenshot of the node's output on an example app.

@flojoy-bot flojoy-bot bot mentioned this pull request Aug 14, 2023
Closed
Roulbac and others added 2 commits August 13, 2023 22:58
@Roulbac
run black formatter
32ebd40
@jjerphan
Update flojoy
80345d6 
This resolves issue on the CI.

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan mentioned this pull request Sep 6, 2023
Closed
jjerphan
jjerphan reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a valuable contribution to me.

To review this PR, I locally updated this branch merging develop (now used as a base branch), performed a few required changes, and pushed it on my fork for now: https://github.com/jjerphan/nodes/commits/reda-torchscript-classifier/).

Note related to this PR: we might want to take some time to think of reorganizing the AI_ML section.

I have a few comments and questions.

AI_ML/CLASSIFICATION/TORCHSCRIPT_CLASSIFIER/TORCHSCRIPT_CLASSIFIER_test_.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
AI_ML/CLASSIFICATION/ONE_HOT_ENCODING/ONE_HOT_ENCODING.py Outdated Show resolved Hide resolved
AI_ML/CLASSIFICATION/ONE_HOT_ENCODING/ONE_HOT_ENCODING_test_.py Outdated Show resolved Hide resolved
AI_ML/CLASSIFICATION/TORCHSCRIPT_CLASSIFIER/app.txt Outdated Show resolved Hide resolved
AI_ML/CLASSIFICATION/TORCHSCRIPT_CLASSIFIER/assets/President_Barack_Obama.jpg Outdated Show resolved Hide resolved
AI_ML/CLASSIFICATION/TORCHSCRIPT_CLASSIFIER/assets/mbnet_v3_small.torchscript Outdated Show resolved Hide resolved
@Roulbac Roulbac changed the base branch from main to develop September 7, 2023 00:28
@flojoy-bot flojoy-bot bot mentioned this pull request Sep 7, 2023
Merged
@Roulbac Roulbac mentioned this pull request Sep 7, 2023
Open
jjerphan
jjerphan approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@jjerphan jjerphan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @Roulbac.

Just one last side-note.

I let you squash (not to have the intermediary commit for the serialized model) and merge when ready.

AI_ML/CLASSIFICATION/TORCHSCRIPT_CLASSIFIER/TORCHSCRIPT_CLASSIFIER_test_.py Show resolved Hide resolved
@Roulbac Roulbac merged commit 28b5a18 into develop Sep 8, 2023
5 checks passed
@jjerphan jjerphan deleted the reda-torchscript-classifier branch September 8, 2023 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Roulbac @jjerphan