Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-30890] This image is now purescript-tools, similar to haskell-tools #2

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

onslaughtq
Copy link
Member

We now build amd64 and arm64 versions of a purescript-tools image. We use bookworm as the Debian version because the trixie unstable version is not currently supported by nodesource.

The spago utility is being built from source, so that we have a version that works on all of our developer arm64 machines. This utility does not officially support arm64 so there may still be some issues with it.

We now build amd64 and arm64 versions of a purescript-tools image. We
use `bookworm` as the Debian version because the `trixie` unstable version
is not currently supported by nodesource.

The spago utility is being built from source, so that we have a version
that works on all of our developer arm64 machines. This utility does not
officially support arm64 so there may still be some issues with it.
README.md Outdated
docker build . -t flipstone/purescript-arm64:0.15.4
docker push
./build-image.sh build-arch-tag
./build-image.sh push-arch-tag

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these the same commands as AMD64?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, the commands are exactly the same for both architectures.

Copy link

@ylafrance ylafrance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, AFAICT 👍

Adds instructions on how to test locally, and adds an option to
`./build-image` for building locally.
@onslaughtq onslaughtq merged commit 01ca28f into main Aug 8, 2023
3 checks passed
@onslaughtq onslaughtq deleted the onslaughtq/sc-30890/make-purescript-tools branch November 1, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants