Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picopass: enum to track auth method #198

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Picopass: enum to track auth method #198

merged 3 commits into from
Apr 9, 2024

Conversation

bettse
Copy link
Collaborator

@bettse bettse commented Apr 7, 2024 •
edited by skotopes
Loading

What's new

  • Tracking auth method so we can display data better

Verification

  • Turn on debug logging
  • Read card
  • see [D][PicopassSceneReadCardSuccess] Auth: Key in logs

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse bettse marked this pull request as ready for review April 7, 2024 05:26
@skotopes
Copy link
Member

skotopes commented Apr 8, 2024

Please merge dev )

@skotopes skotopes merged commit c91677a into flipperdevices:dev Apr 9, 2024
2 checks passed
@bettse bettse deleted the picopass_auth_enum branch April 9, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

Assignees
No one assigned
Labels
app:picopass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bettse @skotopes