Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3745] Write NTAG password and PACK to gen4 special pages #190

Merged
merged 6 commits into from
Apr 9, 2024
Merged

[FL-3745] Write NTAG password and PACK to gen4 special pages #190

merged 6 commits into from
Apr 9, 2024

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Mar 22, 2024 •
edited by skotopes
Loading

What's new

Verification

  • Write a NTAG/Ultralight card with custom password and PACK to a Gen4 card, check that they get written correctly

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@Astrrra Astrrra marked this pull request as ready for review March 22, 2024 05:02
@Astrrra Astrrra marked this pull request as draft March 24, 2024 18:57
@Astrrra Astrrra marked this pull request as ready for review March 24, 2024 19:02
skotopes
skotopes previously approved these changes Mar 26, 2024
View reviewed changes
@skotopes skotopes marked this pull request as draft April 8, 2024 07:24
@Astrrra Astrrra marked this pull request as ready for review April 9, 2024 09:26
@skotopes skotopes merged commit e44aa8d into dev Apr 9, 2024
2 checks passed
@skotopes skotopes deleted the astra/3745-gen4-ultralight-password-fix branch April 9, 2024 15:13
@Astrrra Astrrra mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

Assignees
No one assigned
Labels
app:nfc_magic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Astrrra @skotopes @hedger