Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom OSD message via MSP #56

Closed
wants to merge 7 commits into from
Closed

Add support for custom OSD message via MSP #56

wants to merge 7 commits into from

Conversation

Easy4Racing
Copy link

@Easy4Racing Easy4Racing commented May 21, 2023 •
edited
Loading

增加对自定义OSD消息的支持：即可以通过MSP获得来自外设的OSD信息

This will close Issues #47

  1. 增加MSP2协议ID：MSP2_SET_CUSTOM_OSD_INFO 0x3008
  2. 增加OSD元素：CustomMessage
  3. 自定义消息的长度限制为不大于: 30u
  4. 已使用重山飞控测试
    betaflight_4.3.2_EMSRPROTO2_HEX.zip
  5. ESP32测试代码https://github.com/Easy4Racing/esp32_at32_fc_msp_osd

@shanggl
Copy link
Contributor

shanggl commented May 23, 2023

很好的特性，对于室内、小场地练习来说是很好的增强。
有两点小建议：
1、pr一般以简洁为主，1个pr 最小化的commit ， 显然这个pr commit 有点多。是否可以适当正整理一下。
2、新启用了一个 MSP protol id ， 这个建议考虑一下，是否能向 目前bf 的MSP2_SET_TEXT 这个id （0x3007) 靠拢？ 后期好方便合并。

@shanggl shanggl added this to the 4.3.2rc4 milestone May 23, 2023
@shanggl shanggl added the enhancement New feature or request label May 23, 2023
@shanggl shanggl requested a review from DusKing1 May 23, 2023 00:30
DusKing1
DusKing1 requested changes May 23, 2023
View reviewed changes
Copy link
Contributor

@DusKing1 DusKing1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该PR的commit历史过于混乱，许多更改也没有相应的解释，希望能首先清理好代码、注释与commit历史。

@Easy4Racing
Copy link
Author

哈哈，确实挺乱的，第一次提PR。我先关闭PR，整理好再发起。谢谢~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusKing1 DusKing1 DusKing1 requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.3.2rc4
Development

Successfully merging this pull request may close these issues.
3 participants
@Easy4Racing @shanggl @DusKing1