Add util to the dependencies for impagination
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binary-search-tree requires `util`, but does not enumerate it as a dependency. This is a known issue with it louischatriot/node-binary-search-tree#14 This adds `util` as a primary dependency so that this require will not fail. While we're fixing up meta-information, this adds build time artifacts `/lib` and `/yarn.lock` to the ignore list.
|
Woot! Thanks @cowboyd for taking care of this. Hoping to get this off of the alpha release soon. Thanks for the help |
This was referenced Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary-search-tree requires
util, but does not enumerate it as a dependency. This is a known issue with it louischatriot/node-binary-search-tree#14This adds
utilas a primary dependency so that this require will not fail. While we're fixing up meta-information, this adds build time artifacts/liband/yarn.lockto the ignore list.Fixes #38 and #40