Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flex properties to safelist #198

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

miguelperez
Copy link

I submitted the question as an issue, but then figured it is better to submit a PR. #197

https://css-tricks.com/snippets/css/a-guide-to-flexbox/

@flavorjones
Copy link
Owner

@miguelperez Thanks so much for the kind PR, and especially thanks for the idiomatic test coverage!

Here are the properties being added, with links to the MDN docs for each:

Generally speaking, this PR looks good, I just want to spend some time to understand each of these properties (primarily to ensure we're not introducing any security risk) but based on the names and concepts I think that's unlikely to raise any issues.

Optimistically, I should have time to review and merge, and cut a release by the end of the week.

@miguelperez
Copy link
Author

glad to help.

@flavorjones flavorjones merged commit 3ad9607 into flavorjones:master Nov 25, 2020
@flavorjones
Copy link
Owner

Shipped in https://github.com/flavorjones/loofah/releases/tag/v2.8.0!

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants