Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheels for 1.0.1 #41

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Wheels for 1.0.1 #41

merged 5 commits into from
Sep 12, 2024

Conversation

lgarrison
Copy link
Member

Opening a PR to work on MacOS wheel builds for upcoming version 1.0.1. finufft 2.3 changed/improved the wheel builds, so we probably want to try to match what they're doing.

@lgarrison lgarrison force-pushed the macos-ci-1.0.1 branch 3 times, most recently from 01571dc to be6aa1b Compare September 12, 2024 21:09
…or users who install from sdist/source

work on -Werror

pass env var into container

try fix quoting

ci: use config-settings instead of environment vars

fix define syntax

remove debug statement
…builds"

This reverts commit 874992a.

Wheel builds appear to be working.
@lgarrison
Copy link
Member Author

This also fixed OpenMP on MacOS ARM!

I also prophylactically disabled -Werror for regular source builds but kept it enabled on CI. I don't think we want user source/sdist installs breaking over warnings.

@lgarrison lgarrison merged commit 489b2cc into main Sep 12, 2024
8 checks passed
@lgarrison lgarrison deleted the macos-ci-1.0.1 branch September 12, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant