Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos-base/coreos-init: drop daemon-reload command #1937

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tormath1
Copy link
Contributor

With the recent systemd upgrade we do not need to reload the systemd daemon anymore.

This pulls:


With the recent systemd upgrade we do not need to reload the systemd
daemon anymore

Signed-off-by: Mathieu Tortuyaux <[email protected]>
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I read it correctly, in sdk_container/src/third_party/coreos-overlay/coreos/config/env/sys-apps/systemd we could use After=systemd-sysext.service instead of After=ensure-sysext.service

This ensures that the Systemd daemon is reloaded once the sysext image merged.

Signed-off-by: Mathieu Tortuyaux <[email protected]>
@pothos
Copy link
Member

pothos commented Apr 18, 2024

Some more problems, even if the Flatcar extensions would set EXTENSION_RELOAD_MANAGER they still need to use .upholds/ symlinks instead of .wants.

ZFS: multi-user.target.wants/zfs.targetmulti-user.target.upholds/zfs.target
Containerd: multi-user.target.wants/containerd.service
AWS: multi-user.target.wants/ntpd.service
Azure: multi-user.target.wants/chronyd.service
GCE: multi-user.target.wants/ntpd.service

One way is to patch WantedBy= to be UpheldBy and then the enablement with systemctl enable would work.

Copy link

Build action triggered: https://github.com/flatcar/scripts/actions/runs/8738383351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants