Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rewrite SubtreeRetainer into Typescript #3137

Merged
merged 2 commits into from
Oct 30, 2021
Merged

chore: rewrite SubtreeRetainer into Typescript #3137

merged 2 commits into from
Oct 30, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Oct 28, 2021 •
edited
Loading

Progresses #3533

Changes proposed in this pull request:

As per title

Reviewers should focus on:

N/A

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.2 milestone Oct 28, 2021
@davwheat davwheat self-assigned this Oct 28, 2021
askvortsov1
askvortsov1 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, any errors with tsc?

@davwheat
Copy link
Member Author

Shouldn't be, no. VS Code didn't complain of any issues in the file itself.

@davwheat davwheat merged commit a0a0697 into master Oct 30, 2021
@davwheat davwheat deleted the dw/subtree-retainer-ts branch October 30, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@SychO9 SychO9 SychO9 approved these changes

@dsevillamartin dsevillamartin Awaiting requested review from dsevillamartin

Assignees

@davwheat davwheat

Labels
type/cleanup
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@davwheat @SychO9 @askvortsov1