fix: agent install instructions #2292

moshloop · 2024-09-17T13:27:44Z

No description provided.

vercel · 2024-09-17T13:27:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
aws-preview	✅ Ready (Inspect)	Visit Preview	Nov 1, 2024 0:34am
flanksource-ui	✅ Ready (Inspect)	Visit Preview	Nov 1, 2024 0:34am

netlify · 2024-09-17T13:27:59Z

✅ Deploy Preview for goofy-euclid-75956c ready!

Name	Link
🔨 Latest commit	`57591e4`
🔍 Latest deploy log	https://app.netlify.com/sites/goofy-euclid-75956c/deploys/6724c8598d12120008bea6d0
😎 Deploy Preview	https://deploy-preview-2292--goofy-euclid-75956c.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-09-17T13:27:59Z

✅ Deploy Preview for clerk-saas-ui ready!

Name	Link
🔨 Latest commit	`57591e4`
🔍 Latest deploy log	https://app.netlify.com/sites/clerk-saas-ui/deploys/6724c859c603e70008cb4a23
😎 Deploy Preview	https://deploy-preview-2292--clerk-saas-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-09-17T13:31:52Z

✅ Deploy Preview for flanksource-demo-stable ready!

Name	Link
🔨 Latest commit	`57591e4`
🔍 Latest deploy log	https://app.netlify.com/sites/flanksource-demo-stable/deploys/6724c85912249600086a5f86
😎 Deploy Preview	https://deploy-preview-2292--flanksource-demo-stable.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

moshloop · 2024-09-19T08:18:50Z

@mainawycliffe - the schedule is not pulling through, can we just remove it ?

moshloop · 2024-09-22T07:10:13Z

@mainawycliffe there are sill differences in the values -

Can we create a Helm Component like https://github.com/flanksource/docs/blob/main/common/src/components/Helm.jsx - the values are dynamic and single-sourced

mainawycliffe · 2024-09-24T06:02:47Z

@moshloop The current component is dynamic; I had something similar originally, but I found the template syntax to lead to more issues compared to Handlesbar for both the Yaml and CLI (you would end up need handle all nullable options, which meant a small change could make the template incorrect), they take in the same data object, but return a string based on Yaml handlebar template or the command to run for the CLI, I think the handlebar template for the Yaml and CLI command passing in data object for replacement is far much easier compared to using the template syntax. Other than that, both components work similarly.

src/components/Agents/InstalAgentInstruction/CLIInstallAgent.tsx

src/ui/HelmSnippet/__tests__/__snapshots__/CLISnippet.unit.test.tsx.snap

src/ui/HelmSnippet/CLISnippet.tsx

src/ui/HelmSnippet/FluxSnippet.tsx

Update FluxInstallAgent.tsx Update CLIInstallAgent.tsx Update CLIInstallAgent.unit.test.tsx Update FluxInstallAgent.unit.test.tsx Update CLIInstallAgent.tsx Update CLIInstallAgent.unit.test.tsx refactor: lift up the data composition to parent component chore: fix failing tests chore: fix issue after running npm i fix: make the values being passed to helm & flux template consistent and external fix: fix issues

…nstructions Update src/ui/HelmSnippet/CLISnippet.tsx Co-authored-by: Moshe Immerman <[email protected]> chore: update manifests chore: fix failing tests

vercel bot deployed to Preview – aws-preview September 17, 2024 13:38 View deployment

vercel bot deployed to Preview – flanksource-ui September 17, 2024 13:38 View deployment

moshloop assigned mainawycliffe Sep 19, 2024

mainawycliffe force-pushed the fix-agent-install branch 2 times, most recently from 648c461 to 186a1db Compare September 19, 2024 06:59

vercel bot deployed to Preview – aws-preview September 19, 2024 07:08 View deployment

vercel bot deployed to Preview – flanksource-ui September 19, 2024 07:11 View deployment

mainawycliffe force-pushed the fix-agent-install branch from 186a1db to d175c92 Compare September 20, 2024 21:28

vercel bot deployed to Preview – aws-preview September 20, 2024 21:31 View deployment

vercel bot deployed to Preview – flanksource-ui September 20, 2024 21:34 View deployment

vercel bot deployed to Preview – flanksource-ui September 22, 2024 07:00 View deployment

vercel bot deployed to Preview – aws-preview September 22, 2024 07:02 View deployment

mainawycliffe force-pushed the fix-agent-install branch from 811b65e to 709996c Compare September 24, 2024 06:15

vercel bot deployed to Preview – flanksource-ui September 24, 2024 06:19 View deployment

vercel bot deployed to Preview – aws-preview September 24, 2024 06:24 View deployment

mainawycliffe force-pushed the fix-agent-install branch from 709996c to 2ad1045 Compare September 24, 2024 07:09

vercel bot deployed to Preview – flanksource-ui September 24, 2024 07:12 View deployment

vercel bot deployed to Preview – aws-preview September 24, 2024 07:15 View deployment

mainawycliffe force-pushed the fix-agent-install branch from 2ad1045 to 1856c4d Compare September 27, 2024 06:58

vercel bot deployed to Preview – aws-preview September 27, 2024 07:11 View deployment

vercel bot deployed to Preview – flanksource-ui September 27, 2024 07:16 View deployment

moshloop commented Sep 27, 2024

View reviewed changes

src/components/Agents/InstalAgentInstruction/CLIInstallAgent.tsx Outdated Show resolved Hide resolved

mainawycliffe force-pushed the fix-agent-install branch from 1856c4d to d746069 Compare October 9, 2024 07:43

moshloop commented Oct 22, 2024

View reviewed changes

src/ui/HelmSnippet/__tests__/__snapshots__/CLISnippet.unit.test.tsx.snap Outdated Show resolved Hide resolved

vercel bot deployed to Preview – flanksource-ui October 22, 2024 10:01 View deployment

vercel bot deployed to Preview – aws-preview October 22, 2024 10:04 View deployment

mainawycliffe force-pushed the fix-agent-install branch from b760010 to 7efcfac Compare October 22, 2024 10:10

vercel bot deployed to Preview – aws-preview October 22, 2024 10:15 View deployment

vercel bot deployed to Preview – flanksource-ui October 22, 2024 10:19 View deployment

mainawycliffe force-pushed the fix-agent-install branch from 7efcfac to 3570b9b Compare October 30, 2024 06:53

vercel bot deployed to Preview – flanksource-ui October 30, 2024 06:58 View deployment

vercel bot deployed to Preview – aws-preview October 30, 2024 07:02 View deployment

moshloop commented Oct 30, 2024

View reviewed changes

src/ui/HelmSnippet/CLISnippet.tsx Outdated Show resolved Hide resolved

moshloop commented Oct 30, 2024

View reviewed changes

src/ui/HelmSnippet/CLISnippet.tsx Outdated Show resolved Hide resolved

moshloop commented Oct 30, 2024

View reviewed changes

src/ui/HelmSnippet/FluxSnippet.tsx Outdated Show resolved Hide resolved

moshloop commented Oct 30, 2024

View reviewed changes

src/ui/HelmSnippet/FluxSnippet.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview – aws-preview October 30, 2024 08:09 View deployment

vercel bot deployed to Preview – flanksource-ui October 30, 2024 08:12 View deployment

vercel bot deployed to Preview – flanksource-ui October 30, 2024 15:59 View deployment

vercel bot deployed to Preview – aws-preview October 30, 2024 16:02 View deployment

mainawycliffe force-pushed the fix-agent-install branch from 541cd28 to 7cd4d49 Compare October 31, 2024 14:12

vercel bot deployed to Preview – flanksource-ui October 31, 2024 14:17 View deployment

vercel bot deployed to Preview – aws-preview October 31, 2024 14:22 View deployment

mainawycliffe force-pushed the fix-agent-install branch from 7cd4d49 to d447edd Compare October 31, 2024 16:34

vercel bot deployed to Preview – aws-preview October 31, 2024 16:46 View deployment

vercel bot deployed to Preview – flanksource-ui October 31, 2024 16:51 View deployment

mainawycliffe added 2 commits November 1, 2024 15:22

refactor: extract helm installation snippet from agent installation i…

57591e4

…nstructions Update src/ui/HelmSnippet/CLISnippet.tsx Co-authored-by: Moshe Immerman <[email protected]> chore: update manifests chore: fix failing tests

mainawycliffe force-pushed the fix-agent-install branch from d447edd to 57591e4 Compare November 1, 2024 12:23

vercel bot deployed to Preview – aws-preview November 1, 2024 12:29 View deployment

vercel bot deployed to Preview – flanksource-ui November 1, 2024 12:34 View deployment

moshloop merged commit 5de2c24 into main Nov 11, 2024
15 of 17 checks passed

moshloop deleted the fix-agent-install branch November 11, 2024 19:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: agent install instructions #2292

fix: agent install instructions #2292

moshloop commented Sep 17, 2024

vercel bot commented Sep 17, 2024 •

edited

Loading

netlify bot commented Sep 17, 2024 •

edited

Loading

netlify bot commented Sep 17, 2024 •

edited

Loading

netlify bot commented Sep 17, 2024 •

edited

Loading

moshloop commented Sep 19, 2024

moshloop commented Sep 22, 2024

mainawycliffe commented Sep 24, 2024

fix: agent install instructions #2292

fix: agent install instructions #2292

Conversation

moshloop commented Sep 17, 2024

vercel bot commented Sep 17, 2024 • edited Loading

netlify bot commented Sep 17, 2024 • edited Loading

✅ Deploy Preview for goofy-euclid-75956c ready!

netlify bot commented Sep 17, 2024 • edited Loading

✅ Deploy Preview for clerk-saas-ui ready!

netlify bot commented Sep 17, 2024 • edited Loading

✅ Deploy Preview for flanksource-demo-stable ready!

moshloop commented Sep 19, 2024

moshloop commented Sep 22, 2024

mainawycliffe commented Sep 24, 2024

vercel bot commented Sep 17, 2024 •

edited

Loading

netlify bot commented Sep 17, 2024 •

edited

Loading

netlify bot commented Sep 17, 2024 •

edited

Loading

netlify bot commented Sep 17, 2024 •

edited

Loading