Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kratos Login Flow #1499

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

mainawycliffe
Copy link
Contributor

@mainawycliffe mainawycliffe commented Nov 14, 2023

Closes #1443

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit 05c3cbf
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/65683a792d94f0000828ddc1
😎 Deploy Preview https://deploy-preview-1499--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit 05c3cbf
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/65683a79cb43a60008eb62f8
😎 Deploy Preview https://deploy-preview-1499--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit 05c3cbf
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/65683a79c4cb6100081b8076
😎 Deploy Preview https://deploy-preview-1499--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mainawycliffe mainawycliffe marked this pull request as draft November 14, 2023 13:50
@mainawycliffe mainawycliffe force-pushed the 1443-improve-ux-kratos-login-related-components-1 branch from 7da66b7 to d78f255 Compare November 17, 2023 06:18
@mainawycliffe mainawycliffe marked this pull request as ready for review November 17, 2023 06:19
@mainawycliffe mainawycliffe force-pushed the 1443-improve-ux-kratos-login-related-components-1 branch 5 times, most recently from c43986c to 474dd0d Compare November 20, 2023 09:52
src/components/Authentication/Kratos/KratosLogin.tsx Dismissed Show dismissed Hide dismissed
src/components/Authentication/Kratos/KratosLogin.tsx Dismissed Show dismissed Hide dismissed
@mainawycliffe
Copy link
Contributor Author

@moshloop this is the PR for Logon Issues

@mainawycliffe mainawycliffe force-pushed the 1443-improve-ux-kratos-login-related-components-1 branch 3 times, most recently from b6668f3 to 95b485d Compare November 27, 2023 08:43
@mainawycliffe mainawycliffe changed the title fix: revert the login form to example code and update ory client Improve Kratos Login Flow Nov 27, 2023
@moshloop
Copy link
Member

@mainawycliffe - I get an 500 error after logging in?

@mainawycliffe mainawycliffe force-pushed the 1443-improve-ux-kratos-login-related-components-1 branch 2 times, most recently from 2a184c8 to 2989a81 Compare November 28, 2023 18:20
@moshloop
Copy link
Member

@mainawycliffe Why are we pinning to 13.4.8 ? It should be at least 13.4.20.canary+ with the memory fixes

@mainawycliffe mainawycliffe force-pushed the 1443-improve-ux-kratos-login-related-components-1 branch 3 times, most recently from 6892b6a to d146a28 Compare November 30, 2023 07:24
@mainawycliffe
Copy link
Contributor Author

@moshloop downgraded to v13.4.16 and everything is working as expected

@mainawycliffe
Copy link
Contributor Author

For storybook, we will need to merged #1530 first

Tag #1443

fix: revert the login form to example code and update ory client

fix: fix issue with redirect after login and update kratos login flow
fix: fix sign in with microsoft not working
@mainawycliffe mainawycliffe force-pushed the 1443-improve-ux-kratos-login-related-components-1 branch from d146a28 to 05c3cbf Compare November 30, 2023 07:32
@moshloop moshloop merged commit 5b429f4 into main Dec 1, 2023
12 of 14 checks passed
@moshloop moshloop deleted the 1443-improve-ux-kratos-login-related-components-1 branch December 1, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the UX for Kratos Login and Related components
2 participants