Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1477-gauge-property-renderer #1488

Merged
merged 4 commits into from
Nov 16, 2023
Merged

1477-gauge-property-renderer #1488

merged 4 commits into from
Nov 16, 2023

Conversation

mainawycliffe
Copy link
Contributor

Closes #1477

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit df37641
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/6555c5bff4e657000890bf7e
😎 Deploy Preview https://deploy-preview-1488--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit df37641
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/6555c5bf0acf120008ad82e9
😎 Deploy Preview https://deploy-preview-1488--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mainawycliffe mainawycliffe force-pushed the 1477-gauge-property-renderer branch from 270a47a to 988036a Compare November 8, 2023 20:34
Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit df37641
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/6555c5bf7a057c0008101a42
😎 Deploy Preview https://deploy-preview-1488--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mainawycliffe mainawycliffe force-pushed the 1477-gauge-property-renderer branch from 988036a to a160298 Compare November 9, 2023 14:55
@mainawycliffe mainawycliffe marked this pull request as ready for review November 9, 2023 14:55
@mainawycliffe mainawycliffe force-pushed the 1477-gauge-property-renderer branch from a160298 to 5640791 Compare November 9, 2023 16:08
@moshloop
Copy link
Member

moshloop commented Nov 10, 2023

@moshloop
Copy link
Member

@mainawycliffe ^

@mainawycliffe mainawycliffe force-pushed the 1477-gauge-property-renderer branch 4 times, most recently from 1f75175 to 1c80e59 Compare November 15, 2023 09:07
@moshloop
Copy link
Member

@mainawycliffe Can we left align the value and the bar in the side panel? I think also the font color is not consistent with other headlines

@mainawycliffe mainawycliffe force-pushed the 1477-gauge-property-renderer branch from 1c80e59 to a98662f Compare November 16, 2023 07:01
@mainawycliffe mainawycliffe force-pushed the 1477-gauge-property-renderer branch from a98662f to b5e1b00 Compare November 16, 2023 07:04
Closes #1477

fix: fix issues raised in PR

fix: reduce width

fix: avoid wrapping of text

fix: improve gauge
@mainawycliffe mainawycliffe force-pushed the 1477-gauge-property-renderer branch from b5e1b00 to df37641 Compare November 16, 2023 07:33
@moshloop moshloop merged commit 64601d3 into main Nov 16, 2023
12 of 14 checks passed
@moshloop moshloop deleted the 1477-gauge-property-renderer branch November 16, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gauge property renderer
2 participants