refactor: improve the canary modal layout #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mainawycliffe It is only showing 1 label, it show show enough to fill the entire row and they have a button to show more (expanding the row, not in a popover) + use the blue badges - also remove the text "labels"
There dialog height should be height - 10-20px
|
mainawycliffe
force-pushed
the
1288-canary-detail-modal-improvements
branch
3 times, most recently
from
1e3f492 to
9a5c7a2
Compare
|
@mainawycliffe I am getting this error: Cannot read properties of undefined (reading 'localeCompare') |
|
mainawycliffe
force-pushed
the
1288-canary-detail-modal-improvements
branch
from
9a5c7a2 to
dab2d93
Compare
Closes #1288 fix: fix height issues chore: show labels until full width fix: remove bg issues fix: fix height issue in the table
mainawycliffe
force-pushed
the
1288-canary-detail-modal-improvements
branch
from
dab2d93 to
4837b24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1288