Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1453-treat-check-names-grouping #1470

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

mainawycliffe
Copy link
Contributor

Closes #1434
Closes #1453

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit ab22105
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/6543c1d625221d0008c86591
😎 Deploy Preview https://deploy-preview-1470--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit ab22105
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/6543c1d643fa7d0008d62052
😎 Deploy Preview https://deploy-preview-1470--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit ab22105
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/6543c1d6d0eabb00086e0402
😎 Deploy Preview https://deploy-preview-1470--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mainawycliffe mainawycliffe force-pushed the 1453-treat-check-names-grouping branch 3 times, most recently from 85da351 to 249466d Compare November 2, 2023 11:49
@mainawycliffe mainawycliffe marked this pull request as ready for review November 2, 2023 11:50
@moshloop
Copy link
Member

moshloop commented Nov 2, 2023

@mainawycliffe We need to handle the case of a single item - it strips off the prefix, but then then there is no group header

@moshloop
Copy link
Member

moshloop commented Nov 2, 2023

@mainawycliffe We need to handle the case of a single item - it strips off the prefix, but then then there is no group header

there is also groups with 2 / 0 - we cal also remove the spacing so thats its just 2/2

fix: fix a few refactor issue

fix: fix failing build

chore: move the columns to canary directory
Closes #1453

fix: group by / instead of -

chore: normalize group checks

fix: fix issue reading original name
Closes #1434

fix: use total subrows and remove space
@mainawycliffe mainawycliffe force-pushed the 1453-treat-check-names-grouping branch 2 times, most recently from 704b491 to ab22105 Compare November 2, 2023 15:35
@moshloop moshloop merged commit c8f7b4a into main Nov 2, 2023
9 checks passed
@moshloop moshloop deleted the 1453-treat-check-names-grouping branch November 2, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat '/' in check names as grouping Canary table - grouping latency / uptime
2 participants