Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1409-health-dropdown-click-target-text-not-button #1466

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

mainawycliffe
Copy link
Contributor

Closes #1409

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit 3357833
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/653e51cdc26ade0008cdca7b
😎 Deploy Preview https://deploy-preview-1466--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit 3357833
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/653e51cd1282c8000863d8b7
😎 Deploy Preview https://deploy-preview-1466--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit 3357833
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/653e51cd55097900091feccd
😎 Deploy Preview https://deploy-preview-1466--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mainawycliffe mainawycliffe force-pushed the 1409-health-dropdown-click-target-text-not-button branch from dab08ed to cccddcf Compare October 27, 2023 18:20
)}
</div>
<div
className="flex ml-2 text-sm text-gray-700 capitalize bold hover:text-gray-900 px-3 py-1 pl-0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The margin is not clickable

Suggested change
className="flex ml-2 text-sm text-gray-700 capitalize bold hover:text-gray-900 px-3 py-1 pl-0"
className="flex text-sm text-gray-700 capitalize bold hover:text-gray-900 px-3 py-1"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moshloop We need to set the padding to 0 on the left side in order to make the space in between look even.

The margin issue should be better now.

@mainawycliffe mainawycliffe force-pushed the 1409-health-dropdown-click-target-text-not-button branch from cccddcf to 3357833 Compare October 29, 2023 12:36
@moshloop moshloop merged commit 4d9cb5d into main Oct 30, 2023
7 checks passed
@moshloop moshloop deleted the 1409-health-dropdown-click-target-text-not-button branch October 30, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health dropdown click target is on the text only not on the button
2 participants