1451-connection-properties-need-stored-mapstring-string #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mainawycliffe Is this not something we can in global presubmit handling ? |
|
May be with a hook before sending data to the backend, this is very specific to properties and the data as currently structured in the form, doesn't have a property field and get converted by the presubmit hook where necessary. |
mainawycliffe
force-pushed
the
1451-connection-properties-need-stored-mapstring-string
branch
from
c058700 to
7573ea2
Compare
mainawycliffe
force-pushed
the
1451-connection-properties-need-stored-mapstring-string
branch
from
78f1a05 to
70eda18
Compare
moshloop
deleted the
1451-connection-properties-need-stored-mapstring-string
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1451