1393-add-icon-config-scrapers #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mainawycliffe - I don't see the icons anywhere ? |
|
@moshloop they field? Should be next to the schedule field, inside the form section |
|
@mainawycliffe config scrapers don't need an icon field, they need in icon the table in the same way connections have a connection icon in the table |
mainawycliffe
force-pushed
the
1393-add-icon-config-scrapers
branch
from
0df44f7 to
5694c85
Compare
|
Ah, I see. Will make the changes. |
mainawycliffe
force-pushed
the
1393-add-icon-config-scrapers
branch
from
5694c85 to
69f48d3
Compare
|
What will the icon be based on, the name? |
mainawycliffe
force-pushed
the
1393-add-icon-config-scrapers
branch
from
69f48d3 to
a377740
Compare
mainawycliffe
force-pushed
the
1393-add-icon-config-scrapers
branch
from
a377740 to
d6c8089
Compare
mainawycliffe
force-pushed
the
1393-add-icon-config-scrapers
branch
from
d6c8089 to
60a79cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1393