Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1391-memory-cpu-formatting-issues #1407

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Conversation

mainawycliffe
Copy link
Contributor

@mainawycliffe mainawycliffe commented Sep 18, 2023

Refactored the FormatProperty component for performance by moving all the calculations to useMemo and making it easier to understand.

Closes #1391

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit 5b8ffcb
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/65279ef29f1019000863c389
😎 Deploy Preview https://deploy-preview-1407--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit 5b8ffcb
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/65279ef2d9236d00095f16ac
😎 Deploy Preview https://deploy-preview-1407--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit 5b8ffcb
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/65279ef2968385000803017a
😎 Deploy Preview https://deploy-preview-1407--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mainawycliffe mainawycliffe force-pushed the 1391-memory-cpu-formatting-issues branch from 041a280 to aa8395e Compare September 20, 2023 06:18
@moshloop
Copy link
Member

@mainawycliffe - The tooltips are still just showing the percentage ?

@mainawycliffe mainawycliffe force-pushed the 1391-memory-cpu-formatting-issues branch 2 times, most recently from ee3eaa9 to 23d7a4e Compare September 21, 2023 12:04
@mainawycliffe mainawycliffe marked this pull request as draft September 27, 2023 06:56
@mainawycliffe mainawycliffe force-pushed the 1391-memory-cpu-formatting-issues branch from 23d7a4e to d859001 Compare October 4, 2023 04:16
@mainawycliffe mainawycliffe marked this pull request as ready for review October 4, 2023 04:17
@mainawycliffe mainawycliffe force-pushed the 1391-memory-cpu-formatting-issues branch from d859001 to 3b8df05 Compare October 12, 2023 05:58
@mainawycliffe mainawycliffe force-pushed the 1391-memory-cpu-formatting-issues branch from 3b8df05 to 5b8ffcb Compare October 12, 2023 07:23
@moshloop moshloop merged commit b469aa5 into main Oct 13, 2023
7 checks passed
@moshloop moshloop deleted the 1391-memory-cpu-formatting-issues branch October 13, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory / CPU formatting issues
2 participants