Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-order change and analysis modal titles and add overflow #1405

Merged

Conversation

mainawycliffe
Copy link
Contributor

Overflow on last item now shows ellipses

Closes #1379

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit 56a624a
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/650bf74ef56ee5000800ae48
😎 Deploy Preview https://deploy-preview-1405--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit 56a624a
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/650bf74e074bad0008d9be50
😎 Deploy Preview https://deploy-preview-1405--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit 56a624a
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/650bf74eb191150008e7e1f4
😎 Deploy Preview https://deploy-preview-1405--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@moshloop
Copy link
Member

@mainawycliffe can you check the catalogs panel - we seem to have lost the overflow ellipses there
Screenshot 2023-09-18 at 10 25 17

@mainawycliffe
Copy link
Contributor Author

@moshloop which link is this? I am looking for one to check if it's fixed, can't find one with long catalog names in the panel.

@mainawycliffe mainawycliffe force-pushed the 1379-changeanalysis-modal-title-long-resource-names-wraps branch from c11c82c to e163c18 Compare September 18, 2023 17:33
@moshloop
Copy link
Member

@mainawycliffe It looks like we also have a modal overflow issue if you click on one of the AttachVolume events - can we not force all modal bodies globally to scroll overflow ?

Screenshot 2023-09-19 at 12 14 45

@mainawycliffe
Copy link
Contributor Author

@moshloop let me re-design the modal for this, it should be straight forward to achieve that for the modals.

Overflow on last item now shows ellipses

Closes #1379
@moshloop moshloop force-pushed the 1379-changeanalysis-modal-title-long-resource-names-wraps branch from e163c18 to 56a624a Compare September 21, 2023 07:57
@moshloop moshloop merged commit 7938b56 into main Sep 21, 2023
@moshloop moshloop deleted the 1379-changeanalysis-modal-title-long-resource-names-wraps branch September 21, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change/Analysis Modal title with long resource names wraps
2 participants