1353-components-playbooks #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mainawycliffe
force-pushed
the
1353-components-playbooks
branch
4 times, most recently
from
6e0b747 to
93491a9
Compare
mainawycliffe
force-pushed
the
1353-components-playbooks
branch
5 times, most recently
from
6e4f3e0 to
3283b3c
Compare
|
@moshloop this is good to go as well |
mainawycliffe
force-pushed
the
1353-components-playbooks
branch
3 times, most recently
from
587d6a3 to
e801159
Compare
|
@mainawycliffe Can we change the button into menu button called Playbooks - which then loads the list of playbooks that can be run from /playbooks/list - https://github.com/flanksource/incident-commander/blob/main/playbook/controllers.go#L167 |
|
@moshloop got it |
mainawycliffe
force-pushed
the
1353-components-playbooks
branch
5 times, most recently
from
6f16c64 to
581e5e9
Compare
mainawycliffe
force-pushed
the
1353-components-playbooks
branch
from
581e5e9 to
367a9b6
Compare
|
@moshloop is something like this what you had in mind?
|
mainawycliffe
force-pushed
the
1353-components-playbooks
branch
3 times, most recently
from
53e69a3 to
23d6904
Compare
mainawycliffe
force-pushed
the
1353-components-playbooks
branch
2 times, most recently
from
ea4aabd to
5991538
Compare
This is added to both the configs and component side panel Closes #1353 feat: add dropdown for components to submit playbook runs Build on top of #1352 PR Closes #1353 fix: close modal on save fix: fix submit relaoding full page and wrong endpoint fix: fix playbook submission params feat: add run playbook dropdown to configs sidepanel fix: fix issue with dropdown menu item hover
fix: make row clickable for sidepanel fix: fix duration issue with side panel
fix: fix imports refactor: fix and organize imports
mainawycliffe
force-pushed
the
1353-components-playbooks
branch
4 times, most recently
from
ea462eb to
36d7344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on top of the #1357 PR
Closes #1353