chore: include created by details in catalog change api #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
force-pushed
the
catalog-change-created-by
branch
4 times, most recently
from
5724bff to
eac8454
Compare
moshloop
reviewed
May 2, 2024
query/config_changes.go
Outdated
Comment on lines
165
to
166
| AuthorName string `json:"author_name,omitempty"` | ||
| AuthorAvatar string `json:"author_avatar,omitempty"` |
There was a problem hiding this comment.
I don't think we need to include these - The vast majority of changes will not be linked to a person and we can do the lookup and cache of person -> name, avatar client side
There was a problem hiding this comment.
So just return source, external_created_by and created_by and let frontend decide ?
moshloop
force-pushed
the
catalog-change-created-by
branch
from
8642094 to
2f9a9d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #708