feat: add error column to notifications table

models/notifications.go

@@ -23,6 +23,9 @@ type Notification struct {
 	UpdatedAt      time.Time           `json:"updated_at" time_format:"postgres_timestamp" gorm:"<-:false"`
 	CreatedAt      time.Time           `json:"created_at" time_format:"postgres_timestamp" gorm:"<-:false"`
 	DeletedAt      *time.Time          `json:"deleted_at,omitempty"`
+
+	// Error stores errors in notification filters (if any)
+	Error *string `json:"error,omitempty"`
 }
 
 func (n *Notification) HasRecipients() bool {

schema/notifications.hcl

@@ -10,6 +10,10 @@ table "notifications" {
     type    = sql("text[]")
     comment = "a list of events this notification is for."
   }
+  column "error" {
+    null = true
+    type = text
+  }
   column "title" {
     null = true
     type = text

views/007_events.sql

@@ -218,48 +218,6 @@ WHERE
 GROUP BY
   name;
 
--- Insert team updates in event_queue
-CREATE
-OR REPLACE FUNCTION insert_team_in_event_queue () RETURNS TRIGGER AS $$
-BEGIN
-  IF TG_OP = 'DELETE' THEN
-    INSERT INTO event_queue(name, properties) VALUES ('team.delete', jsonb_build_object('team_id', OLD.id))
-    ON CONFLICT (name, properties) DO UPDATE SET created_at = NOW(), last_attempt = NULL, attempts = 0;
-  ELSE
-    INSERT INTO event_queue(name, properties) VALUES ('team.update', jsonb_build_object('team_id', NEW.id))
-    ON CONFLICT (name, properties) DO UPDATE SET created_at = NOW(), last_attempt = NULL, attempts = 0;
-  END IF;
-
-  RETURN NULL;
-END
-$$ LANGUAGE plpgsql;
-
-CREATE
-OR REPLACE TRIGGER team_enqueue
-AFTER INSERT OR UPDATE OR DELETE ON teams FOR EACH ROW
-EXECUTE PROCEDURE insert_team_in_event_queue ();
-
--- Create new event on any updates on the notifications table
-CREATE OR REPLACE FUNCTION notifications_trigger_function()
-RETURNS TRIGGER AS $$
-BEGIN
-    IF TG_OP = 'DELETE' THEN
-        INSERT INTO event_queue(name, properties) VALUES ('notification.delete', jsonb_build_object('id', OLD.id))
-        ON CONFLICT (name, properties) DO UPDATE SET created_at = NOW(), last_attempt = NULL, attempts = 0;
-    ELSE
-        INSERT INTO event_queue(name, properties) VALUES ('notification.update', jsonb_build_object('id', NEW.id))
-        ON CONFLICT (name, properties) DO UPDATE SET created_at = NOW(), last_attempt = NULL, attempts = 0;
-    END IF;
-
-    RETURN NULL;
-END
-$$ LANGUAGE plpgsql;
-
-CREATE OR REPLACE TRIGGER notification_update_enqueue
-AFTER INSERT OR UPDATE OR DELETE ON notifications
-FOR EACH ROW
-EXECUTE PROCEDURE notifications_trigger_function ();
-
 -- Publish Notify on new events
 CREATE OR REPLACE FUNCTION notify_new_events_function()
 RETURNS TRIGGER AS $$

views/020_teams_triggers.sql

@@ -1,14 +1,26 @@
+-- Notify on any updates on the teams table
 CREATE OR REPLACE FUNCTION handle_team_updates()
 RETURNS TRIGGER AS $$
 BEGIN
+  IF TG_OP = 'DELETE' THEN
+    PERFORM pg_notify('table_activity', TG_TABLE_NAME || ' ' || OLD.id);
+    RETURN NULL;
+  END IF;
+
   IF OLD.deleted_at IS NULL AND NEW.deleted_at IS NOT NULL THEN
     DELETE FROM team_components WHERE team_id = OLD.id;
   END IF;
+
+  IF OLD.spec != NEW.spec THEN
+    UPDATE notifications SET error = NULL WHERE team_id = NEW.id;
+  END IF;
+
+  PERFORM pg_notify('table_activity', TG_TABLE_NAME || ' ' || NEW.id);
 
-  RETURN NEW;
+  RETURN NULL;
 END
 $$ LANGUAGE plpgsql;
 
 CREATE OR REPLACE TRIGGER team_updates
-AFTER UPDATE ON teams
+AFTER UPDATE OR DELETE ON teams
 FOR EACH ROW EXECUTE PROCEDURE handle_team_updates();

views/021_notification.sql

@@ -0,0 +1,35 @@
+-- Notify on any updates/deletes on the notifications table
+CREATE OR REPLACE FUNCTION handle_notifications_updates_deletes()
+RETURNS TRIGGER AS $$
+BEGIN
+  IF TG_OP = 'DELETE' THEN
+    PERFORM pg_notify('table_activity', TG_TABLE_NAME || ' ' || OLD.id);
+  ELSE
+    PERFORM pg_notify('table_activity', TG_TABLE_NAME || ' ' || NEW.id);
+  END IF;
+
+  RETURN NULL;
+END
+$$ LANGUAGE plpgsql;
+
+CREATE OR REPLACE TRIGGER handle_notifications_updates_deletes_trigger
+AFTER UPDATE OR DELETE ON notifications
+FOR EACH ROW
+EXECUTE PROCEDURE handle_notifications_updates_deletes();
+
+-- Handle before updates for notifications
+CREATE OR REPLACE FUNCTION reset_notification_error_before_update()
+RETURNS TRIGGER AS $$
+BEGIN
+  IF OLD.filter != NEW.filter OR OLD.custom_services != NEW.custom_services OR OLD.team_id != NEW.team_id THEN
+    NEW.error = NULL;
+  END IF;
+
+  RETURN NEW;
+END
+$$ LANGUAGE plpgsql;
+
+CREATE OR REPLACE TRIGGER reset_notification_error_before_update_trigger
+BEFORE UPDATE ON notifications
+FOR EACH ROW
+EXECUTE PROCEDURE reset_notification_error_before_update();