fix: event_queue fixes #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* do not insert unknown component status updates to event_queue
adityathebe
force-pushed
the
fix/pg_notify_async_events
branch
from
2b970fd to
6576142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async events, like
notification.send, are created from the application; unlike sync events which are created with DB triggers. Due to this reason, we do not have PG notify triggers when async events are inserted. As a result, async event consumers never run in real-time and rely on the 1 minute timeout. (This was fine so far, because no matter which event was inserted, the pgnotify was picked up by all consumers. But now we have specific pg notify channels)Instead of publishing pgnotify during insertion from multiple trigger functions, this PR adds a trigger on the event_queue table itself.
Also
Resolves: flanksource/canary-checker#1259