feat: new notification send history table #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshloop
reviewed
Sep 18, 2023
moshloop
reviewed
Sep 18, 2023
|
@adityathebe can we also create Cleanup function to remove notifications older than 30d ? |
moshloop
reviewed
Sep 18, 2023
.github/workflows/test.yaml
Outdated
| @@ -51,7 +51,7 @@ jobs: | |||
|
|
|||
| services: | |||
| postgres: | |||
| image: postgres | |||
| image: postgres:15 | |||
There was a problem hiding this comment.
The latest is 16 so I was actually trying to downgrade it since we've been running on v15 so far.
For some reason, migration failed with v16.
What's our preferred version?
There was a problem hiding this comment.
It looks like all major clouds now support 15, but if we bump it from 14 to 15 here, we also need to bump it everywhere else
There was a problem hiding this comment.
but if we bump it from 14 to 15 here
I think this Github action has been running on 15 for quite some time now since it was the default.
But if we're running on 14 everywhere else, I'll tag this to 14 here as well.
moshloop
reviewed
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.