chore: revamp component health logic (#1004)

* chore: revamp component health logic

* chore: add health comparison

* chore: simplify health logic

models/common.go

@@ -28,6 +28,18 @@ const (
 	HealthWarning   Health = "warning"
 )
 
+func WorseHealth(healths ...Health) Health {
+	worst := HealthHealthy
+	for _, h := range healths {
+		if h == HealthUnhealthy {
+			return HealthUnhealthy
+		} else if h == HealthWarning {
+			worst = HealthWarning
+		}
+	}
+	return worst
+}
+
 func init() {
 	logger.SkipFrameContains = append(logger.SkipFrameContains, "duty/models")
 }

models/components.go

@@ -178,7 +178,7 @@ func (c Component) GetStatus() (string, error) {
 	return string(c.Status), nil
 }
 
-func (c Component) GetHealth() (string, error) {
+func (c Component) GetHealth() (Health, error) {
 	if c.HealthExpr != "" {
 		env := map[string]any{
 			"summary": c.Summary.AsEnv(),
@@ -188,24 +188,23 @@ func (c Component) GetHealth() (string, error) {
 			return "", fmt.Errorf("failed to evaluate health expression %s: %v", c.HealthExpr, err)
 		}
 
-		return out, nil
+		return Health(out), nil
 	}
 
+	// When HealthExpr is not defined, we take worse of checks, children and the component itself
+	var allHealths []Health
 	if h := lo.FromPtr(c.Health); h != "" {
-		return string(h), nil
+		allHealths = append(allHealths, h)
 	}
 
-	if c.Summary.Healthy > 0 && c.Summary.Unhealthy > 0 {
-		return string(types.ComponentStatusWarning), nil
-	} else if c.Summary.Unhealthy > 0 {
-		return string(types.ComponentStatusUnhealthy), nil
-	} else if c.Summary.Warning > 0 {
-		return string(types.ComponentStatusWarning), nil
-	} else if c.Summary.Healthy > 0 {
-		return string(types.ComponentStatusHealthy), nil
-	} else {
-		return string(types.ComponentStatusInfo), nil
+	for h, count := range c.Checks {
+		if count > 0 {
+			allHealths = append(allHealths, Health(h))
+		}
 	}
+
+	allHealths = append(allHealths, lo.Map(c.Components, func(item *Component, _ int) Health { return lo.FromPtr(item.Health) })...)
+	return WorseHealth(allHealths...), nil
 }
 
 func (c *Component) AsMap(removeFields ...string) map[string]any {

query/topology.go

@@ -395,7 +395,7 @@ func generateTree(components models.Components, compChildrenMap map[string]model
 		if health, err := c.GetHealth(); err != nil {
 			return nil, err
 		} else {
-			c.Health = lo.ToPtr(models.Health(health))
+			c.Health = lo.ToPtr(health)
 		}
 
 		if status, err := c.GetStatus(); err != nil {