Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new colorsceme + update css #7

Closed
wants to merge 43 commits into from
Closed

add new colorsceme + update css #7

wants to merge 43 commits into from

Conversation

awwpotato
Copy link
Contributor

No description provided.

azaleacolburn and others added 30 commits October 23, 2024 08:05
@awwpotato awwpotato marked this pull request as draft November 17, 2024 03:38
@azaleacolburn
Copy link
Member

azaleacolburn commented Nov 17, 2024

Overall, this is amazing work! One small request I have is that the the grid / flex styling be more consistent across action input stages. For example, the intake and eject screen is arranged vertically and doesn't fill the screen, while the scoring screen buttons fill the screen.
Screenshot 2024-11-16 at 8 02 28 PM
Screenshot 2024-11-16 at 8 13 29 PM

Also, unrelated, but you should probably name branches more specifically in the future, there are likely to be several styling PRs going forward : )

@awwpotato awwpotato marked this pull request as ready for review November 18, 2024 02:46
Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry, I should have been clearer, I prefer when the buttons take up as much of the screen as possible.

As in like, this is good and I think that other screens should have buttons that take up this much space as well.
image

@azaleacolburn azaleacolburn mentioned this pull request Nov 19, 2024
@azaleacolburn azaleacolburn self-requested a review November 19, 2024 18:36
@azaleacolburn
Copy link
Member

I rolled back some commits, so git forced me to make a new branch because apparently rewriting git history is bad practice :P
So this PR is on #9

@azaleacolburn azaleacolburn deleted the firmegan/styling branch November 19, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants