Timeline Modification Verification #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mingchickens1540/inflatedchickens into azalea/complex-state-machine
…mingchickens1540/inflatedchickens into azalea/complex-state-machine
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When users edit the timeline, by either rearranging or deleting ActionItems, they may crease illegal timelines. For example, if they swap set of reciprocal Intake and Eject Actions. Now, if they create an invalid timeline, the exact ActionItems that they made illegal will have a warning on them and they won't be able to close the timeline until they resolve all warnings.
Features:
Note
This PR creates a new class that's used to verify a timeline, this class could be used eventually to encapsulate some logic from
ActionInputs.svelte, however, that's beyond the scope of this PR and likely this BunnyBots season.