Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose xwayland.Server's pid #207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Nov 27, 2024

  1. expose xwayland.Server's pid

    wlroots wants to fork() and waitpid() on the result:
    
    https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/871646d22522141c45db2c0bfa1528d595bb69df
    
    (this code *almost* does the right thing, but only does SIG_BLOCK in the
    first fork, not the parent...)
    
    applications using wlroots which have SIGCHLD handlers installed may
    interfere with this, so expose the server pid so they can use WNOWAIT
    trickery to avoid reaping this pid, to allow wlroots to do so.
    
    Maybe this is the wrong patch to fix the described issue: maybe pywayland
    should block SIGCHLD (via signal.pthread_sigmask(), since applications may
    be multithreaded, especially if they use asyncio) and then do
    wlr_xwayland_server_create(), then unblock it for users? But either way,
    seems like people might want to see the pid here.
    
    Signed-off-by: Tycho Andersen <[email protected]>
    tych0 committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a059e51 View commit details
    Browse the repository at this point in the history